fixed logs issue #19931

[mattisafur]

fixes #19931

when running:
$ minikube logs --file log.txt --last-start-only
or
$ minikube logs --file log.txt --audit

before:

• outputs requested log to stdout
• creates a blank log.txt file

after:

• outputs requested log to file
• no output to stdout

I'm pretty new to go, let me know if there's something I should change.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: mattisafur / name: mattisafur (58aadf1)

[k8s-ci-robot]

Welcome @mattisafur!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @mattisafur. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[minikube-bot]

Can one of the admins verify this patch?

[ComradeProgrammer]

/ok-to-test

[mattisafur]

/retest

[mattisafur]

Whenever one of the maintainers gets to looking at this (it's really not major, take you time :3), I basically replaced two if statements that return to a switch statement and changed a little the way outputting to a file is done. letting you know because the git diff looks kind of confusing

Just letting you know, with this change there's a function that is not anywhere anymore, logs.OutputOffline, it was only used for outputting the whole log to a file and seems kind of redundant. it's still in the code.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mattisafur
Once this PR has been reviewed and has the lgtm label, please assign spowelljr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20138) |
+----------------+----------+---------------------+
| minikube start | 51.2s    | 53.4s               |
| enable ingress | 17.4s    | 15.5s               |
+----------------+----------+---------------------+

Times for minikube ingress: 18.5s 15.5s 15.1s 18.5s 19.5s
Times for minikube (PR 20138) ingress: 16.0s 15.0s 16.0s 15.0s 15.5s

Times for minikube start: 52.2s 50.6s 51.8s 51.5s 50.1s
Times for minikube (PR 20138) start: 55.5s 49.6s 52.9s 54.9s 54.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20138) |
+----------------+----------+---------------------+
| minikube start | 22.2s    | 22.4s               |
| enable ingress | 12.5s    | 12.6s               |
+----------------+----------+---------------------+

Times for minikube start: 20.5s 20.4s 20.7s 24.1s 25.1s
Times for minikube (PR 20138) start: 23.4s 20.2s 24.3s 20.6s 23.4s

Times for minikube ingress: 12.7s 12.3s 12.8s 12.3s 12.2s
Times for minikube (PR 20138) ingress: 12.8s 12.8s 12.3s 12.3s 12.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20138) |
+----------------+----------+---------------------+
| minikube start | 22.3s    | 21.2s               |
| enable ingress | 25.8s    | 26.2s               |
+----------------+----------+---------------------+

Times for minikube start: 19.5s 24.1s 22.7s 22.9s 22.3s
Times for minikube (PR 20138) start: 23.0s 19.6s 22.0s 22.8s 18.8s

Times for minikube ingress: 22.8s 22.8s 37.7s 22.8s 22.8s
Times for minikube (PR 20138) ingress: 22.7s 22.8s 39.3s 22.8s 23.3s