Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: trigger enterprise qa tests for dev releases #109

Merged
merged 6 commits into from
Mar 12, 2024
Merged

feat: trigger enterprise qa tests for dev releases #109

merged 6 commits into from
Mar 12, 2024

Conversation

emil2k
Copy link
Contributor

@emil2k emil2k commented Mar 11, 2024 •
edited
Loading

  • Removed logs service subchart from enterprise as it was placing certificates in the same secret as the API, which caused intermittent TLS errors.
  • Removed conflicting ArgoCD source file.

Checklist:

  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My CI is green.

@emil2k emil2k added the enhancement New feature or request label Mar 11, 2024
@emil2k emil2k self-assigned this Mar 11, 2024
@emil2k emil2k force-pushed the emil/tkc-1472-trigger-qa-tests-automatically-with-deployments-to-pro-cloud branch from 5fc32bb to 1d6c741 Compare March 11, 2024 10:06
@emil2k emil2k marked this pull request as ready for review March 11, 2024 11:05
ypoplavs
ypoplavs approved these changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@ypoplavs ypoplavs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, but a secret for the logs service need to fixed later.

@emil2k emil2k merged commit a89681b into develop Mar 12, 2024
3 checks passed
@emil2k emil2k deleted the emil/tkc-1472-trigger-qa-tests-automatically-with-deployments-to-pro-cloud branch March 12, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ypoplavs ypoplavs ypoplavs approved these changes

@dejanzele dejanzele Awaiting requested review from dejanzele

Assignees

@emil2k emil2k

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emil2k @ypoplavs @ed382