Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testkube-cloud-secrets added #33

Merged
merged 10 commits into from
Sep 14, 2023
Merged

testkube-cloud-secrets added #33

merged 10 commits into from
Sep 14, 2023

Conversation

emamihe
Copy link
Contributor

@emamihe emamihe commented Jul 30, 2023

regarding having the external secrets via helm chart

@emamihe emamihe requested a review from dejanzele July 30, 2023 16:43
@emamihe emamihe self-assigned this Jul 30, 2023
name: {{ $value | lower | replace "_" "-" }}
spec:
data:
- remoteRef:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do the range function here? I'd rather we have 1 ES CRD with a well-known name which we can easily add to the Cloud API Deployment

@dejanzele
Copy link
Collaborator

Can you please also create a README.md for this Chart where it describes what a developer need to do?

@emamihe
Copy link
Contributor Author

emamihe commented Jul 31, 2023

updated

@emamihe
Copy link
Contributor Author

emamihe commented Aug 18, 2023

@dejanzele could you please check again?

key: {{ $value }}
secretKey: {{ $key }}
{{ end }}
refreshInterval: 60s
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can increase the interval to 5m, we won't update secrets that often

charts/testkube-cloud-ui/values.yaml Outdated Show resolved Hide resolved
charts/testkube-cloud-api/values.yaml Outdated Show resolved Hide resolved
charts/testkube-cloud-ui/templates/external-secret.yaml Outdated Show resolved Hide resolved
@ypoplavs
Copy link
Collaborator

how was the ClusterSecretStore created? manually?

@emamihe
Copy link
Contributor Author

emamihe commented Aug 23, 2023

how was the ClusterSecretStore created? manually?

since the config for ClusterSecretStore in one time, I think the best place to include that config is within external-secrets operator installation within Terraform manifest

@ypoplavs
Copy link
Collaborator

I'm moving k8s-addons charts from TF to be deployed by Argo, I will include ClusterIssuer there as well.

@emamihe emamihe merged commit 774dc11 into develop Sep 14, 2023
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants