-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testkube-cloud-secrets added #33
Conversation
name: {{ $value | lower | replace "_" "-" }} | ||
spec: | ||
data: | ||
- remoteRef: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you do the range
function here? I'd rather we have 1 ES CRD with a well-known name which we can easily add to the Cloud API Deployment
Can you please also create a README.md for this Chart where it describes what a developer need to do? |
updated |
@dejanzele could you please check again? |
key: {{ $value }} | ||
secretKey: {{ $key }} | ||
{{ end }} | ||
refreshInterval: 60s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can increase the interval to 5m
, we won't update secrets that often
how was the ClusterSecretStore created? manually? |
since the config for ClusterSecretStore in one time, I think the best place to include that config is within external-secrets operator installation within Terraform manifest |
I'm moving k8s-addons charts from TF to be deployed by Argo, I will include ClusterIssuer there as well. |
regarding having the external secrets via helm chart