Skip to content

Commit

Permalink
removed comments
Browse files Browse the repository at this point in the history
  • Loading branch information
exu committed Nov 22, 2021
1 parent bf3f7ca commit 6ffe900
Showing 1 changed file with 0 additions and 18 deletions.
18 changes: 0 additions & 18 deletions pkg/jobs/jobclient.go
Original file line number Diff line number Diff line change
Expand Up @@ -216,24 +216,6 @@ func (c *JobClient) TailPodLogs(ctx context.Context, podName string, logs chan [
if scanner.Err() != nil {
c.Log.Errorw("scanner error", "error", scanner.Err())
}

// for {
// // TODO is it bulletprof for huge messages ?
// // we need to parse output.Output struct
// buf := make([]byte, 20000)
// numBytes, err := stream.Read(buf)
// if numBytes == 0 || err == io.EOF {
// c.Log.Debug("no more logs", "error", err)
// break
// }

// if err != nil {
// c.Log.Errorw("error when tailing logs stream", "error", err)
// return
// }

// logs <- buf[:numBytes]
// }
}()
return
}
Expand Down

0 comments on commit 6ffe900

Please sign in to comment.