hotfix ga settings

docker-compose.yaml

@@ -4,6 +4,8 @@ services:
     container_name: tracetest
     image: kubeshop/tracetest
     build: .
+    environment:
+      - VERSION=1.0
     volumes:
       - type: bind
         source: ./server/config.yaml

server/analytics/analytics.go

@@ -39,7 +39,7 @@ func Init(cfg config.GoogleAnalytics, appName, appVersion string) error {
 	}
 
 	defaultClient = ga{
-		enabled:       cfg.Enabled,
+		enabled:       true,
 		measurementID: cfg.MeasurementID,
 		secretKey:     cfg.SecretKey,
 		appVersion:    appVersion,
@@ -52,12 +52,16 @@ func Init(cfg config.GoogleAnalytics, appName, appVersion string) error {
 }
 
 func CreateAndSendEvent(name, category string) error {
-	if defaultClient.ready() {
+	if !defaultClient.ready() {
 		return fmt.Errorf("uninitalized client. Call analytics.Init")
 	}
 	return defaultClient.CreateAndSendEvent(name, category)
 }
 
+func Ready() bool {
+	return defaultClient.ready()
+}
+
 type ga struct {
 	enabled       bool
 	appVersion    string
@@ -115,7 +119,6 @@ func (ga ga) sendEvent(e event) error {
 		},
 	}
 
-	fmt.Printf("ga %+v\n", payload)
 	err := ga.sendValidationRequest(payload)
 	if err != nil {
 		fmt.Println("err validation", err)

server/analytics/analytics_test.go

@@ -0,0 +1,46 @@
+package analytics_test
+
+import (
+	"testing"
+
+	"github.com/kubeshop/tracetest/analytics"
+	"github.com/kubeshop/tracetest/config"
+	"github.com/stretchr/testify/assert"
+)
+
+func TestReadyness(t *testing.T) {
+	analytics.Init(config.GoogleAnalytics{Enabled: false}, "test", "1.0")
+	assert.True(t, analytics.Ready())
+
+	analytics.Init(config.GoogleAnalytics{Enabled: true}, "test", "1.0")
+	assert.False(t, analytics.Ready())
+
+	analytics.Init(config.GoogleAnalytics{
+		Enabled:       true,
+		MeasurementID: "1",
+		SecretKey:     "2",
+	}, "test", "1.0")
+	assert.True(t, analytics.Ready())
+
+	analytics.Init(config.GoogleAnalytics{
+		Enabled:       true,
+		MeasurementID: "1",
+		SecretKey:     "2",
+	}, "test", "1.0")
+	assert.True(t, analytics.Ready())
+
+	analytics.Init(config.GoogleAnalytics{
+		Enabled:       true,
+		MeasurementID: "1",
+		SecretKey:     "2",
+	}, "", "1.0")
+	assert.False(t, analytics.Ready())
+
+	analytics.Init(config.GoogleAnalytics{
+		Enabled:       true,
+		MeasurementID: "1",
+		SecretKey:     "2",
+	}, "test", "")
+	assert.False(t, analytics.Ready())
+
+}