fix: append callback parameter after joining url path (#3993)

kubeshop · Aug 28, 2024 · 0a57188 · 0a57188
1 parent 6ec7f6b
commit 0a57188
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/cli/pkg/oauth/oauth.go b/cli/pkg/oauth/oauth.go
@@ -59,11 +59,13 @@ func (s *OAuthServer) GetAuthJWT() error {
  return fmt.Errorf("failed to start oauth server: %w", err)
  }
 
- loginUrl, err := neturl.JoinPath(s.frontendEndpoint, fmt.Sprintf("oauth?callback=%s", url))
+ loginUrl, err := neturl.JoinPath(s.frontendEndpoint, "oauth")
  if err != nil {
  return fmt.Errorf("could not build path: %w", err)
  }
 
+ loginUrl += fmt.Sprintf("?callback=%s", url)
+
  ui := ui.DefaultUI
  err = ui.OpenBrowser(loginUrl)
  if err != nil {