Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly display general errors #3995

Merged
merged 3 commits into from
Aug 28, 2024
Merged

fix: correctly display general errors #3995

merged 3 commits into from
Aug 28, 2024

Conversation

schoren
Copy link
Collaborator

@schoren schoren commented Aug 28, 2024

This PR fixes the error handling of the CLI for the run command. It now allows displaying an error instead of silently failing.

It also attempts to parse the error response from the server as a structured error to display nicer messages when possible

Changes

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom video

Screenshot 2024-08-28 at 18 57 35

Add your loom video here if your work can be visualized

Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tracetest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 10:21pm

@@ -357,29 +356,3 @@ func getRequiredGates(gates []string) []openapi.SupportedGates {

return requiredGates
}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this code was unused

@@ -296,8 +296,6 @@ func (a orchestrator) writeJUnitReport(ctx context.Context, r Runner, result Run
return err
}

var source = "cli"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this var was unused

@schoren schoren merged commit 75fef46 into main Aug 28, 2024
38 checks passed
@schoren schoren deleted the fix-error branch August 28, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants