Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update otel demo examples #4018

Merged
merged 3 commits into from
Sep 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ spec:
assertions:
- attr:tracetest.response.status = 200
- name: It added an item correctly into the shopping cart
selector: span[name="oteldemo.CartService/AddItem"]
selector: span[name="POST /oteldemo.CartService/AddItem"]
assertions:
- attr:rpc.grpc.status_code = 0
- attr:grpc.status_code = 0
- attr:app.product.id = "0PUK6V6EV0"
- name: It set the cart item correctly on the database
selector: span[tracetest.span.type="database" name="HMSET" db.system="redis" db.redis.database_index="0"]
Expand Down
4 changes: 2 additions & 2 deletions testing/synthetic-monitoring/otel-demo/05-view-cart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@ spec:
assertions:
- attr:tracetest.response.status = 200
- name: It retrieved the cart items correctly
selector: span[name="oteldemo.CartService/GetCart"]
selector: span[name="POST /oteldemo.CartService/GetCart"]
assertions:
- attr:rpc.grpc.status_code = 0
- attr:grpc.status_code = 0
13 changes: 1 addition & 12 deletions testing/synthetic-monitoring/otel-demo/06-checking-out-cart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -58,17 +58,6 @@ spec:
- attr:rpc.grpc.status_code = 0
- attr:tracetest.selected_spans.count >= 1
- name: The order was sent to be processed asyncronously
selector: span[tracetest.span.type="messaging" name="orders publish" messaging.system="kafka" messaging.destination.name="orders" messaging.destination.kind="topic" messaging.operation="publish"]
selector: span[tracetest.span.type="messaging" name="orders publish" messaging.system="kafka" messaging.destination.name="orders" messaging.operation="publish"]
assertions:
- attr:messaging.destination.name = "orders"
# TODO: Accountability service is not working in our Demo env, we need to understand why
# - name: The order was sent to accountability
# # captures the span emitted by Kafka instrumentation for Go
# selector: span[tracetest.span.type="messaging" name="orders receive" messaging.system="kafka" messaging.destination.name="orders" messaging.destination.kind="topic" messaging.operation="receive"]
# assertions:
# - attr:name = "orders receive"
- name: The order was sent to fraud detection team
# captures the span emitted by Kafka instrumentation for Kotlin
selector: span[tracetest.span.type="messaging" name="orders process" messaging.system="kafka" messaging.operation="process"]
assertions:
- attr:name = "orders process"
2 changes: 1 addition & 1 deletion testing/synthetic-monitoring/otel-demo/_testsuite.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
type: TestSuite
spec:
id: pokeshop-demo-test-suite
name: OTel Demo Synthetic tests
name: 'OTel Demo Synthetic tests'
description: Run all Frontend tests enabled in sequence, simulating a process of a user purchasing products on Astronomy store
steps:
- ./01-see-ads.yaml
Expand Down
Loading