Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump multus to v4.1.0 #1865

Closed
wants to merge 1 commit into from
Closed

Conversation

kubevirt-bot
Copy link
Collaborator

bump multus to v4.1.0
Executed by Bumper script

bump multus to v4.1.0

Signed-off-by: CNAO Bump Bot <noreply@github.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M labels Aug 15, 2024
@kubevirt-bot
Copy link
Collaborator Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ramlavi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

sonarcloud bot commented Aug 15, 2024

@oshoval
Copy link
Collaborator

oshoval commented Aug 15, 2024

@RamLavi
Lets see macvtap status here please instead on the release (well it might pass and flake later, in this case we have the previous failure)

@oshoval
Copy link
Collaborator

oshoval commented Aug 15, 2024

https://github.com/kubevirt/cluster-network-addons-operator/actions/runs/10404305217/job/28812491768?pr=1865
looks like cloud hiccup

+ export KUBEVIRT_VERSION=
+ KUBEVIRT_VERSION=
+ ./cluster/kubectl.sh apply -f https://github.com/kubevirt/kubevirt/releases/download//kubevirt-operator.yaml
error: unable to read URL "https://github.com/kubevirt/kubevirt/releases/download//kubevirt-operator.yaml", server reported 404 Not Found, status code=404

@RamLavi
Copy link
Collaborator

RamLavi commented Aug 18, 2024

/retest

@kubevirt-bot
Copy link
Collaborator Author

@kubevirt-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-e2e-cluster-network-addons-operator-macvtap-cni-functests 787b72a link true /test pull-e2e-cluster-network-addons-operator-macvtap-cni-functests
pull-e2e-cnao-multus-dynamic-networks-functests 787b72a link true /test pull-e2e-cnao-multus-dynamic-networks-functests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@RamLavi
Copy link
Collaborator

RamLavi commented Sep 16, 2024

lots of errors here https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_cluster-network-addons-operator/1865/pull-e2e-cnao-multus-dynamic-networks-functests/1824070655604166656

https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_cluster-network-addons-operator/1865/pull-e2e-cluster-network-addons-operator-macvtap-cni-functests/1824070655419617280

adapted this issue to point on this #1858

well manifests were changed so might need some code tweaks

Hey @maiqueb can you take a look at your convenient time?
If we need the multus changes (that are not included in this bump, but might be in the next bump should we manage to convince them to issue a new patch release, that would include k8snetworkplumbingwg/multus-cni#1336) for the network-status annotation change on UDN primary - then we might as well fix what's breaking this bump, cause reason stands that it will also break the next tag.

@RamLavi RamLavi closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants