Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 2D_Fighting_Game #5017

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Conversation

Vaibhav-kesarwani
Copy link
Contributor

PR Description πŸ“œ

Added 2D_Fighting_Game
Fixes #5016


Mark the task you have completed βœ…

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in GameZone's README.md
  • I have added README.md in my Game folder
  • I have added working video of the game in README.md (optional)
  • I have specified the respective issue number for which I have requested the new game.
  • I have added my Game to gamesData.json file and it is loading properly on main website as intended.

Add your screenshots(Optional) πŸ“Έ

Screenshot from 2024-07-29 16-26-46



Thank you soo much for contributing to our repository πŸ’—

@kunjgit
Copy link
Owner

kunjgit commented Jul 29, 2024

Thank you @Vaibhav-kesarwani ,for creating the PR and contributing to our GameZone πŸ’—
Review team will review the PR and will reach out to you soon! πŸ˜‡
Make sure that you have marked all the tasks that you are done with βœ….
Thank you for your patience! πŸ˜€

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge

@ishita-43 ishita-43 added Ready to merge πŸ₯³ level3 Adding new features gssoc GSSoC24 program label labels Jul 29, 2024
@Vaibhav-kesarwani
Copy link
Contributor Author

/assign

@Vaibhav-kesarwani
Copy link
Contributor Author

@kunjgit Please review the PR and merge it

@Vaibhav-kesarwani
Copy link
Contributor Author

@ishita-43 Please merge the PR

@ishita-43
Copy link
Collaborator

@ishita-43 Please merge the PR

Merge will be done by the admin soon

@Vaibhav-kesarwani
Copy link
Contributor Author

@ishita-43 It has already been two days since the PR was raised. and it did not merge yet.

@kunjgit kunjgit merged commit 1bf8386 into kunjgit:main Aug 1, 2024
@kunjgit
Copy link
Owner

kunjgit commented Aug 1, 2024

Thank you @Vaibhav-kesarwani , for your valuable time and contribution in our GameZone πŸ’—.
It’s our GameZone, so Let’s build this GameZone altogether !!🀝
Hoping to see you soon with another PR again πŸ˜‡
Wishing you all the best for your journey into Open SourceπŸš€

@kunjgit kunjgit mentioned this pull request Aug 7, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC24 program label level3 Adding new features Ready to merge πŸ₯³
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New game]: Add Two Player Fighting Game
3 participants