KUNENABLE-161 Add support for Symfony 6.4 to kununu/elasticsearch-bundle #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hugo-goncalves-kununu
commented
Apr 11, 2024
hugo-goncalves-kununu
commented
- Drop support for PHP 8.0 - PHP 8.1 is now the minimum version
- Upgrade PHPUnit to version 10.5
- Refactor some code to take advantage of PHP 8.1 features (read-only properties)
- Fix tests that used deprecated/removed features on PHPUnit 10.5
- Refactor tests to be more PHPUnit 10.5 compliant (e.g. using attributes for data providers, make all data providers static, etc.)
- Update versions of continuous integration components
Upgrade PHPUnit to version 10.5 Refactor some code to take advantage of PHP 8.1 features (read-only properties) Fix tests that used deprecated/removed features on PHPUnit 10.5 Refactor tests to be more PHPUnit 10.5 compliant (e.g. using attributes for data providers, make all data providers static, etc.) Update versions of continuous integration components
csizmazia
requested changes
Apr 11, 2024
| types: [ opened, synchronize, reopened ] | ||
| push: | ||
| branches: | ||
| - master |
There was a problem hiding this comment.
since we will open PRs upon version branches, we should keep them in this list.
There was a problem hiding this comment.
I'm not really sure if that will work. The master branch has a higher PHP version that the other branches
There was a problem hiding this comment.
not sure either... let's see...
There was a problem hiding this comment.
We will see when we actually open a PR on one of those branches. Then we will check what can we do to solve it
|
csizmazia
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.