Fix oops in str.__repr__, how did tests not catch that

kuroko-lang · Mar 6, 2024 · c865e0d · c865e0d
1 parent 66d8133
commit c865e0d
Showing 1 changed file with 11 additions and 11 deletions.
diff --git a/src/obj_str.c b/src/obj_str.c
@@ -893,16 +893,6 @@ KRK_Method(str,__repr__) {
 
 	for (char * c = AS_CSTRING(argv[0]); c < end; ++c) {
 		unsigned char ch = *c;
-		if (ch < ' ' || ch == 0x7F) {
-			pushStringBuilder(&sb,'\\');
-			pushStringBuilder(&sb,'x');
-			char hex[3];
-			snprintf(hex, 3, "%02x", (unsigned char)*c);
-			pushStringBuilder(&sb,hex[0]);
-			pushStringBuilder(&sb,hex[1]);
-			continue;
-		}
-
 		int addSlash = 0;
 		switch (ch) {
 			/* XXX: Other non-printables should probably be escaped as well. */
@@ -917,7 +907,17 @@ KRK_Method(str,__repr__) {
 			case '\t': addSlash = 1; ch = 't'; break;
 			case '\v': addSlash = 1; ch = 'v'; break;
 			case 27:   addSlash = 1; ch = '['; break;
-			default: break;
+			default:
+				if (ch < ' ' || ch == 0x7F) {
+					pushStringBuilder(&sb,'\\');
+					pushStringBuilder(&sb,'x');
+					char hex[3];
+					snprintf(hex, 3, "%02x", (unsigned char)*c);
+					pushStringBuilder(&sb,hex[0]);
+					pushStringBuilder(&sb,hex[1]);
+					continue;
+				}
+				break;
 		}
 		if (addSlash) krk_pushStringBuilder(&sb,'\\');
 		krk_pushStringBuilder(&sb,ch);