Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

feat: adding metric_url for reth #124

Merged
merged 10 commits into from
Sep 20, 2023
Merged

feat: adding metric_url for reth #124

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5a014e8
feat: adding metric_url for reth
loocapro Sep 14, 2023
5518f89
feat: add node metric info
loocapro Sep 14, 2023
05e5d83
review: fix comments
loocapro Sep 14, 2023
a267780
feat: add execution clients metrics info
cbermudez97 Sep 14, 2023
c4e6828
Merge pull request #1 from NethermindEth/feat/add-el-metrics
loocapro Sep 18, 2023
b73144c
fix conflicts
loocapro Sep 19, 2023
329f398
fix: parameters order for backward compatibility
cbermudez97 Sep 19, 2023
6112c51
Merge pull request #2 from NethermindEth/feat/add-el-metrics
loocapro Sep 19, 2023
be9bdc5
Merge branch 'main' into feat/add_el_metrics
h4ck3rk3y Sep 20, 2023
ad580db
Update ethereumjs_launcher.star
h4ck3rk3y Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/el/besu/besu_launcher.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ def launch(
WS_PORT_NUM,
ENGINE_HTTP_RPC_PORT_NUM,
jwt_secret,
"", # Passing empty metric_url for now
loocapro marked this conversation as resolved.
Show resolved Hide resolved
service_name
)

Expand Down
2 changes: 2 additions & 0 deletions src/el/el_client_context.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ def new_el_client_context(
ws_port_num,
engine_rpc_port_num,
jwt_secret,
metric_url,
loocapro marked this conversation as resolved.
Show resolved Hide resolved
service_name = ""):
return struct(
service_name = service_name,
Expand All @@ -18,4 +19,5 @@ def new_el_client_context(
ws_port_num = ws_port_num,
engine_rpc_port_num = engine_rpc_port_num,
jwt_secret = jwt_secret,
metric_url = metric_url,
)
1 change: 1 addition & 0 deletions src/el/erigon/erigon_launcher.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ def launch(
WS_RPC_PORT_NUM,
ENGINE_RPC_PORT_NUM,
jwt_secret,
"", # Passing empty metric_url for now
loocapro marked this conversation as resolved.
Show resolved Hide resolved
service_name
)

Expand Down
1 change: 1 addition & 0 deletions src/el/ethereumjs/ethereumjs_launcher.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ def launch(
WS_PORT_NUM,
ENGINE_RPC_PORT_NUM,
jwt_secret,
"", # Passing empty metric_url for now
loocapro marked this conversation as resolved.
Show resolved Hide resolved
service_name,
)

Expand Down
1 change: 1 addition & 0 deletions src/el/geth/geth_launcher.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ def launch(
WS_PORT_NUM,
ENGINE_RPC_PORT_NUM,
jwt_secret,
"", # Passing empty metric_url for now
service_name
)

Expand Down
1 change: 1 addition & 0 deletions src/el/nethermind/nethermind_launcher.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ def launch(
WS_PORT_NUM,
ENGINE_RPC_PORT_NUM,
jwt_secret,
"", # Passing empty metric_url for now
service_name
)

Expand Down
3 changes: 3 additions & 0 deletions src/el/reth/reth_launcher.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ def launch(

jwt_secret = shared_utils.read_file_from_service(plan, service_name, jwt_secret_json_filepath_on_client)

metric_url = "http://{0}:{1}".format(service.ip_address, METRICS_PORT_NUM)
loocapro marked this conversation as resolved.
Show resolved Hide resolved

return el_client_context.new_el_client_context(
"reth",
"", # reth has no enr
Expand All @@ -106,6 +108,7 @@ def launch(
WS_PORT_NUM,
ENGINE_RPC_PORT_NUM,
jwt_secret,
metric_url,
service_name,
)

Expand Down