Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

login APIに失敗したときに、センシティブな情報がログに出力されてしまう問題を修正しました。 #651

Merged
merged 4 commits into from
May 28, 2024

Conversation

yuji38kwmt
Copy link
Collaborator

@yuji38kwmt yuji38kwmt commented May 28, 2024

APIに失敗したとき、パスワードがマスクされずにログに出力されるのを修正しました。

変更前

ERROR    : 2024-05-28 13:37:11,053 : annofabapi.api                 : HTTP error occurred :: {'response': {'status_code': 401, 'text': '{"errors":[{"error_code":"LOGIN_FAILED","message":"ユーザー名またはパスワードが違います","ext":{}}],"context":
...
 'request': {'http_method': 'POST', 'url': 'https://annofab.com/api/v1/login', 'body': b'{"user_id": "alice", "password": "alice_password"}...

@yuji38kwmt yuji38kwmt changed the title Test 2024 ああ May 28, 2024
@yuji38kwmt yuji38kwmt changed the title ああ login APIに失敗したときに、センシティブな情報がログに出力されてしまう問題を修正しました。 May 28, 2024
@yuji38kwmt yuji38kwmt merged commit 93fc20e into main May 28, 2024
3 checks passed
@yuji38kwmt yuji38kwmt deleted the test-2024 branch May 28, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant