Fix clang-tidy errors

kuzudb · Sep 6, 2024 · 1e12a84 · 1e12a84
1 parent 57304f2
commit 1e12a84
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/binder/bind/bind_file_scan.cpp b/src/binder/bind/bind_file_scan.cpp
@@ -141,13 +141,14 @@ std::unique_ptr<BoundBaseScanSource> Binder::bindFileScanSource(const BaseScanSo
     const bool ignoreErrors = config->getOption(CopyConstants::IGNORE_ERRORS_OPTION_NAME,
         CopyConstants::DEFAULT_IGNORE_ERRORS);
     if (ignoreErrors) {
-        extraDataColumns = expression_vector{};
+        expression_vector columnsToAdd;
         for (idx_t i = 0; i < CopyConstants::WARNING_METADATA_NUM_COLUMNS; ++i) {
-            extraDataColumns->push_back(
+            columnsToAdd.push_back(
                 createSingleColumnExpression(CopyConstants::WARNING_METADATA_COLUMN_NAMES[i], *this,
                     LogicalType(CopyConstants::WARNING_METADATA_COLUMN_TYPES[i])));
         }
-        KU_ASSERT(checkExtraDataColumnTypes(extraDataColumns.value()));
+        KU_ASSERT(checkExtraDataColumnTypes(columnsToAdd));
+        extraDataColumns.emplace(std::move(columnsToAdd));
     }
 
     auto info = BoundTableScanSourceInfo(func, std::move(bindData), std::move(inputColumns),