Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong sniff type when sample_size = 1 #4565

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SterlingT3485
Copy link
Collaborator

Description

The rowNum check in SniffNameandTypeDriver::done was wrong.

Fixed it and added test

Fix #4531

Contributor agreement

Copy link

Benchmark Result

Master commit hash: 756486b02abe6c283067935b550c369629985efb
Branch commit hash: 144d1ae68c622b9a61e2ae0f979f2c518cdbaa56

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 653.68 652.51 1.16 (0.18%)
aggregation q28 11764.56 11660.77 103.80 (0.89%)
filter q14 140.44 135.35 5.09 (3.76%)
filter q15 140.94 135.49 5.46 (4.03%)
filter q16 313.99 306.99 7.00 (2.28%)
filter q17 458.57 452.63 5.95 (1.31%)
filter q18 1941.13 1935.17 5.96 (0.31%)
filter zonemap-node 94.32 94.56 -0.24 (-0.25%)
filter zonemap-node-lhs-cast 94.49 94.82 -0.32 (-0.34%)
filter zonemap-rel 5733.36 5724.56 8.80 (0.15%)
fixed_size_expr_evaluator q07 579.38 578.03 1.35 (0.23%)
fixed_size_expr_evaluator q08 808.15 811.74 -3.59 (-0.44%)
fixed_size_expr_evaluator q09 810.61 809.61 1.01 (0.12%)
fixed_size_expr_evaluator q10 243.97 247.06 -3.09 (-1.25%)
fixed_size_expr_evaluator q11 237.52 237.13 0.39 (0.16%)
fixed_size_expr_evaluator q12 235.04 233.69 1.34 (0.57%)
fixed_size_expr_evaluator q13 1465.82 1467.01 -1.19 (-0.08%)
fixed_size_seq_scan q23 125.55 122.17 3.38 (2.77%)
join q29 592.64 646.05 -53.40 (-8.27%)
join q30 1287.94 1442.43 -154.49 (-10.71%)
join q31 8.37 8.23 0.14 (1.74%)
ldbc_snb_ic q35 404.56 538.41 -133.85 (-24.86%)
ldbc_snb_ic q36 128.93 108.10 20.83 (19.27%)
ldbc_snb_is q32 5.95 2.13 3.82 (179.39%)
ldbc_snb_is q33 14.52 12.40 2.12 (17.10%)
ldbc_snb_is q34 1.57 1.45 0.12 (8.33%)
multi-rel multi-rel-large-scan 1226.33 1201.99 24.34 (2.03%)
multi-rel multi-rel-lookup 19.02 5.61 13.41 (239.00%)
multi-rel multi-rel-small-scan 91.60 78.50 13.10 (16.68%)
order_by q25 141.70 139.72 1.98 (1.42%)
order_by q26 459.94 459.89 0.05 (0.01%)
order_by q27 1456.68 1464.05 -7.36 (-0.50%)
scan_after_filter q01 177.29 178.79 -1.50 (-0.84%)
scan_after_filter q02 166.80 164.86 1.94 (1.17%)
shortest_path_ldbc100 q37 96.08 85.73 10.34 (12.07%)
shortest_path_ldbc100 q38 468.90 455.56 13.34 (2.93%)
shortest_path_ldbc100 q39 59.35 61.46 -2.10 (-3.42%)
shortest_path_ldbc100 q40 538.56 519.42 19.14 (3.69%)
var_size_expr_evaluator q03 2089.09 2106.47 -17.38 (-0.83%)
var_size_expr_evaluator q04 2248.93 2243.27 5.66 (0.25%)
var_size_expr_evaluator q05 2663.78 2754.49 -90.71 (-3.29%)
var_size_expr_evaluator q06 1326.96 1327.50 -0.53 (-0.04%)
var_size_seq_scan q19 1453.90 1453.62 0.28 (0.02%)
var_size_seq_scan q20 2754.42 2748.31 6.12 (0.22%)
var_size_seq_scan q21 2279.28 2282.05 -2.77 (-0.12%)
var_size_seq_scan q22 128.61 127.64 0.97 (0.76%)

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.25%. Comparing base (756486b) to head (4d733aa).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4565      +/-   ##
==========================================
+ Coverage   87.24%   87.25%   +0.01%     
==========================================
  Files        1356     1356              
  Lines       56755    56755              
  Branches     7078     7080       +2     
==========================================
+ Hits        49515    49523       +8     
+ Misses       7068     7060       -8     
  Partials      172      172              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Incorrect sniffing result when sample size = 1
1 participant