Merge instances of set viewport/scissor at the API level #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge the API invocations into RenderEncoder. Move the depth range inside the viewport.
EriKWDev
reviewed
Dec 23, 2024
| @@ -295,11 +296,15 @@ pub struct ComputeCommandEncoder<'a> { | |||
| device: &'a Device, | |||
| update_data: &'a mut Vec<u8>, | |||
| } | |||
| //Note: we aren't merging this with `ComputeCommandEncoder` | |||
| // because the destructors are different, and they can't be specialized | |||
| // https://github.com/rust-lang/rust/issues/46893 | |||
There was a problem hiding this comment.
Didn't know about this one
There was a problem hiding this comment.
Quite annoying, honestly! It breaks the API symmetry between standalone types and generic specializations.
I've spent some time experimenting with it and had to throw a lot of stuff out, due to this seemingly minor issue.
There was a problem hiding this comment.
Very surprising it isn't supported :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up to #227
Reducing code and API duplication