change to ordered timings over hashmap #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EriKWDev
force-pushed
the
ErikWDev/ordered-timings
branch
from
512904a to
85defe5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #231
The motivation is that the order of the timings was information that got lost in the current approach but seems present in all implementations.
Same-named data was previously being merged (might have been concidered a feature), though considering how easy it is to get that behavior if so desired I think the blade API not imposing removal of information is better. I prefer reading timings in the order of submission which was previously only possible if names were kept somewhere else in order and if merged same-names were desired.
Particles demo tested on linux with vulkan as well as with metal on M4, macos. Gles compiles on linux.