Improve output when string not equal for long strings #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kward
reviewed
Feb 9, 2019
shunit2
Outdated
| _shunit_assertFail "${shunit_message_:+${shunit_message_} }diff:<${diff_output_}>" | ||
| else | ||
| _shunit_assertFail "${shunit_message_:+${shunit_message_} }expected:<${shunit_expected_}> but was:<${shunit_actual_}>" | ||
| fi | ||
|
|
||
| unset shunit_message_ shunit_expected_ shunit_actual_ |
cbandy
reviewed
Feb 18, 2019
shunit2
Outdated
| @@ -630,7 +630,12 @@ failNotEquals() { | |||
| shunit_actual_=$2 | |||
|
|
|||
| shunit_message_=${shunit_message_%% } | |||
| _shunit_assertFail "${shunit_message_:+${shunit_message_} }expected:<${shunit_expected_}> but was:<${shunit_actual_}>" | |||
| if command [ $(echo "${shunit_expected_}" | wc -l) -gt 10 ] || command [ $(echo "${shunit_actual_}" | wc -l) -gt 10 ]; then | |||
| diff_output_=$(diff <(echo "${shunit_expected_}") <(echo "${shunit_actual_}")) | |||
There was a problem hiding this comment.
I recognize process substitution <() as a Bashism, though I don't know the details.
There was a problem hiding this comment.
This is process substitution, it provides a way of passing the output of a command to another command where pipe is not available. diff takes filenames, but the items that want to be diff'd are in variables.
I suspect this might be why the tests are failing, as it probably doesn't work in other shells.
If anyone has any suggestions on how I can do this differently then let me know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.