-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move test, update requirements #76
Conversation
Added numexpr to requirements. Tests now running. |
One of the tokenizer tests depended on writing a file. Removed it. |
Removed test to fix #77 |
model/base.py did not raise NotImplemented here, The test was looking for that. |
Catching up 20231229 1519
"""Test print_main without distribution""" | ||
print_main(message) | ||
captured = capsys.readouterr() | ||
assert captured.out == message + "\n" | ||
captured = capsys.readout() |
Check warning
Code scanning / Pylint (reported by Codacy)
Undefined variable 'capsys' Warning test
captured = capsys.readouterr() | ||
assert captured.out == message + "\n" | ||
captured = capsys.readout() | ||
assert captured.out == message + "\n" |
Check warning
Code scanning / Pylint (reported by Codacy)
Exactly one space required before comparison Warning test
"""Test print_main without distribution""" | ||
print_main(message) | ||
captured = capsys.readouterr() | ||
assert captured.out == message + "\n" | ||
captured = capsys.readout() |
Check warning
Code scanning / Pylintpython3 (reported by Codacy)
Undefined variable 'capsys' Warning test
@@ -11,11 +11,11 @@ | |||
|
|||
|
|||
# Basic Test | |||
def test_print_main_without_dist(message, capsys): | |||
def test_print_main_without_dist(message): |
Check notice
Code scanning / Pylintpython3 (reported by Codacy)
Redefining name 'message' from outer scope (line 8) Note test
Catching up 202312291935
Fixing tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the base model changes it's supposed to stay as it is
The base model test checks for Not Implemented. If it stays as is, then the test should be removed. |
@evelynmitchell then have them removed so i can accept |
Dine |
move test, update requirements
The test was in the wrong directory:
Moved it to the correct tests location.