Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated release process for ACM #104

Open
4 tasks
koala7659 opened this issue Nov 6, 2023 · 2 comments
Open
4 tasks

Automated release process for ACM #104

koala7659 opened this issue Nov 6, 2023 · 2 comments
Assignees
Labels
area/application-connector Issues or PRs related to application connectivity bv/maintainability Business Value: Maintainability (see ISO 25010)
Milestone

Comments

@koala7659
Copy link
Contributor

koala7659 commented Nov 6, 2023

Description

After consolidating the ACM module, we have to review the release process.

AC:

Relates to

Please consider also this bug: YAML manifests have to be populated as asset to the generated Github release (#325)

@koala7659 koala7659 added this to the Release 1.1.0 milestone Nov 6, 2023
@tobiscr tobiscr added area/application-connector Issues or PRs related to application connectivity bv/maintainability Business Value: Maintainability (see ISO 25010) labels Dec 18, 2023
@tobiscr
Copy link
Contributor

tobiscr commented Dec 29, 2023

Please verify if we can generate synergy effects by combining this issue with #135

@tobiscr tobiscr changed the title Fix prow jobs and makefiles for better module release process Fix and improve release process for ACM Mar 25, 2024
@koala7659 koala7659 modified the milestones: Release 1.1.3, Future Apr 22, 2024
@Disper Disper assigned VOID404 and unassigned m00g3n May 16, 2024
@tobiscr tobiscr changed the title Fix and improve release process for ACM Automated release process for ACM May 16, 2024
@tobiscr
Copy link
Contributor

tobiscr commented Sep 12, 2024

Feedback from @koala7659 after release ACM 1.1.7:

App connector 1.1.7 release process is horrible experience. It should not take more than few hours to make new release and test it. Two days should be max. I couldn't release it during a week. Imagine we have critical bug on production and we say we need one week to release the fix. Here are some problems I identified:

  • The code had lot of tech debt (old dependencies, GH
    actions to update, cross dependencies between components)
  • Waiting for checkmarx approval
  • The build artifacts could not be built without fixing GH Actions
  • Executable from Kaniko was corrupted (should already be fixed by Neighbors)
  • Problem with tests on Kyma cluster
  • Release documentation not valid https://github.tools.sap/kyma/module-manifests/Readme.md - still I must figure out the way to test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/application-connector Issues or PRs related to application connectivity bv/maintainability Business Value: Maintainability (see ISO 25010)
Projects
None yet
Development

No branches or pull requests

4 participants