Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate ACM prow pipelines to GHA #197

Merged
merged 11 commits into from
Apr 4, 2024
Merged

Migrate ACM prow pipelines to GHA #197

merged 11 commits into from
Apr 4, 2024

Conversation

m00g3n
Copy link
Contributor

@m00g3n m00g3n commented Mar 12, 2024 •
edited
Loading

Description
Migrate ACM prow pipelines to GHA.

Changes proposed in this pull request:
Adapt the following tests to run on GHA

  • application-conn-validator
  • application-gateway
  • compass-runtime-agent

Links:

Related issue(s)

@m00g3n m00g3n requested review from a team as code owners March 12, 2024 15:58
@kyma-bot kyma-bot added area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 12, 2024
@m00g3n m00g3n mentioned this pull request Mar 12, 2024
Closed
@m00g3n m00g3n force-pushed the add-app-gateway-k3d-integration-test branch 23 times, most recently from ae544bc to 1c71184 Compare March 13, 2024 12:02
@m00g3n m00g3n force-pushed the add-app-gateway-k3d-integration-test branch 2 times, most recently from 8d7b169 to 4a407eb Compare March 27, 2024 16:23
@m00g3n m00g3n temporarily deployed to compass-runtime-agent March 27, 2024 16:23 — with GitHub Actions Inactive
@m00g3n m00g3n force-pushed the add-app-gateway-k3d-integration-test branch 5 times, most recently from 9c887e9 to b301210 Compare March 27, 2024 17:48
@m00g3n m00g3n force-pushed the add-app-gateway-k3d-integration-test branch 3 times, most recently from d00a140 to e0f64f3 Compare March 28, 2024 13:46
@m00g3n m00g3n force-pushed the add-app-gateway-k3d-integration-test branch from e0f64f3 to 75c3c10 Compare March 29, 2024 09:49
@Disper
Copy link
Member

Disper commented Apr 3, 2024 •
edited
Loading

notes from what @m00g3n is saying

  • we have some commons in kyma that MIGHT be used by other repos, some additional actions might be used
  • tests in ACM were not being run for about 6 months
  • we might need to change repo structure and some doc changes might be also needed

koala7659
koala7659 approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@koala7659 koala7659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 3, 2024
@kyma-bot kyma-bot merged commit 2424fdd into kyma-project:main Apr 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grego952 grego952 grego952 approved these changes

@koala7659 koala7659 koala7659 approved these changes

Assignees

@koala7659 koala7659

@grego952 grego952

Labels
area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@m00g3n @Disper @koala7659 @grego952 @kyma-bot