generated from kyma-project/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compass Runtime Agent - Normalise Compass application names during synchronisation #357
Merged
kyma-bot
merged 17 commits into
kyma-project:main
from
koala7659:normalise-compass-application-name
Sep 30, 2024
Merged
Compass Runtime Agent - Normalise Compass application names during synchronisation #357
kyma-bot
merged 17 commits into
kyma-project:main
from
koala7659:normalise-compass-application-name
Sep 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Sep 23, 2024
kyma-bot
added
cla: yes
Indicates the PR's author has signed the CLA.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Sep 23, 2024
koala7659
changed the title
WIP - Normalise compass application name for Compass Runtime Agent
Normalise compass application name for Compass Runtime Agent
Sep 25, 2024
kyma-bot
removed
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Sep 25, 2024
koala7659
changed the title
Normalise compass application name for Compass Runtime Agent
Normalise Compass application names for Compass Runtime Agent during synchronisation
Sep 25, 2024
koala7659
changed the title
Normalise Compass application names for Compass Runtime Agent during synchronisation
Compass Runtime Agent - Normalise Compass application names during synchronisation
Sep 25, 2024
…names when runtime is specificaly labeled
kyma-bot
added
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
and removed
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Sep 27, 2024
grego952
reviewed
Sep 27, 2024
Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>
Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>
grego952
reviewed
Sep 27, 2024
Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>
grego952
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Changes proposed in this pull request:
isNormalized=false
or such a label is missing on the runtime. At the moment all runtimes in Compass are labeled withisNormalized=true
by default.Note:
The scope is limited only to adjust to upcoming changes of the data received from compass side. We just normalise names of synchronized applications and if there are name conflict we fail synchronization process.
We do not support in App Connector multiple applications with the same names and identification based on some kind of unique ID.
Related issue(s):
Original issue - kyma-project/kyma#10070
Current issue - #290