Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compass Runtime Agent - Normalise Compass application names during synchronisation #357

Merged

Conversation

koala7659
Copy link
Contributor

@koala7659 koala7659 commented Sep 23, 2024

Description:

Changes proposed in this pull request:

  • Extending Compass Runtime Agent synchronization code in order to make Kyma runtime resistent by adding normalization of the received application names. Using original normalization code taken from: https://github.com/kyma-incubator/compass/blob/3fe1796bc7a273d08dff10c53860b9793ff40a23/components/director/pkg/normalizer/normalizer.go#L31
  • The normalization of application names happens when the runtime is labeled with isNormalized=false or such a label is missing on the runtime. At the moment all runtimes in Compass are labeled with isNormalized=true by default.
  • Adding checks during application synchronisation with Compass that detects duplicate application names to be created on Kyma side and in such a case the synchronisation fails.
  • Unit test update, adding new controller tests

Note:

The scope is limited only to adjust to upcoming changes of the data received from compass side. We just normalise names of synchronized applications and if there are name conflict we fail synchronization process.
We do not support in App Connector multiple applications with the same names and identification based on some kind of unique ID.

Related issue(s):
Original issue - kyma-project/kyma#10070
Current issue - #290

@koala7659 koala7659 requested a review from a team as a code owner September 23, 2024 15:58
@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2024
@koala7659 koala7659 marked this pull request as draft September 23, 2024 15:58
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 23, 2024
@koala7659 koala7659 marked this pull request as ready for review September 24, 2024 16:16
@koala7659 koala7659 changed the title WIP - Normalise compass application name for Compass Runtime Agent Normalise compass application name for Compass Runtime Agent Sep 25, 2024
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 25, 2024
@koala7659 koala7659 changed the title Normalise compass application name for Compass Runtime Agent Normalise Compass application names for Compass Runtime Agent during synchronisation Sep 25, 2024
@koala7659 koala7659 self-assigned this Sep 25, 2024
@koala7659 koala7659 changed the title Normalise Compass application names for Compass Runtime Agent during synchronisation Compass Runtime Agent - Normalise Compass application names during synchronisation Sep 25, 2024
@mvshao mvshao self-requested a review September 26, 2024 06:55
@mvshao mvshao self-assigned this Sep 26, 2024
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 27, 2024
@koala7659 koala7659 requested a review from a team as a code owner September 27, 2024 09:19
koala7659 and others added 2 commits September 27, 2024 12:42
koala7659 and others added 2 commits September 27, 2024 13:06
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 30, 2024
@kyma-bot kyma-bot merged commit 9dc7fb6 into kyma-project:main Sep 30, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants