Skip to content

Commit

Permalink
remove unnecessary logs & use type boolean for feature flag
Browse files Browse the repository at this point in the history
  • Loading branch information
chriskari committed Nov 20, 2024
1 parent 132f2fa commit 83b5de7
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions backend/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -83,13 +83,13 @@ const isDocker = process.env.IS_DOCKER === 'true';
const handleRequest = makeHandleRequest();

if (isDocker) {
console.log('Running in dev mode');
// Running in dev mode
// yup, order matters here
serveMonaco(app);
app.use('/backend', handleRequest);
serveStaticApp(app, '/', '/core-ui');
} else {
console.log('Running in prod mode');
// Running in prod mode
handleTracking(app);
app.use('/backend', handleRequest);
}
Expand Down
8 changes: 4 additions & 4 deletions src/state/navigation/extensionsAtom.ts
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ const getExtensionWizards = async (
kubeconfigNamespace = 'kube-public',
currentNamespace: string,
permissionSet: PermissionSetState,
extCustomComponentsEnabled: boolean | undefined,
extCustomComponentsEnabled: boolean,
) => {
if (!fetchFn) {
return null;
Expand Down Expand Up @@ -294,7 +294,7 @@ const getExtensions = async (
kubeconfigNamespace = 'kube-public',
currentNamespace: string,
permissionSet: PermissionSetState,
extCustomComponentsEnabled: boolean | undefined,
extCustomComponentsEnabled: boolean,
) => {
if (!fetchFn) {
return null;
Expand Down Expand Up @@ -461,7 +461,7 @@ export const useGetExtensions = () => {
cluster.currentContext.namespace || 'kube-public',
namespace,
permissionSet,
isExtensibilityCustomComponentsEnabled,
isExtensibilityCustomComponentsEnabled ?? false,
);

const statics = await getStatics(
Expand All @@ -476,7 +476,7 @@ export const useGetExtensions = () => {
cluster.currentContext.namespace || 'kube-public',
namespace,
permissionSet,
isExtensibilityCustomComponentsEnabled,
isExtensibilityCustomComponentsEnabled ?? false,
);

if (!wizardConfigs || !isExtensibilityWizardEnabled) {
Expand Down

0 comments on commit 83b5de7

Please sign in to comment.