remove unnecessary css code from reset.css & some minor adjustments

kyma-project · Dec 9, 2024 · 85357fb · 85357fb
1 parent 49ad3be
commit 85357fb
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 33 deletions.
diff --git a/src/header/Header.tsx b/src/header/Header.tsx
@@ -58,7 +58,7 @@ export function Header() {
     name => name !== cluster?.name,
   );
 
-  const nonBreakableSpaces = (number: int): string => {
+  const nonBreakableSpaces = (number: number): string => {
     let spaces = '';
     for (let i = 0; i < number; i++) {
       spaces += '\u00a0';
@@ -218,7 +218,6 @@ export function Header() {
             text={t('common.labels.version')}
             additionalText={busolaVersion}
             icon="inspect"
-            startsSection
           />
         </MenuItem>
       </Menu>

diff --git a/src/shared/components/DynamicPageComponent/DynamicPageComponent.js b/src/shared/components/DynamicPageComponent/DynamicPageComponent.js
@@ -80,7 +80,7 @@ export const DynamicPageComponent = ({
       );
     });
     // eslint-disable-line react-hooks/exhaustive-deps
-  }, []);
+  }, [className]);
 
   const handleColumnClose = () => {
     window.history.pushState(

diff --git a/src/styles/index.scss b/src/styles/index.scss
@@ -66,10 +66,6 @@ ui5-button::part(button) {
   -webkit-font-smoothing: antialiased;
 }
 
-li {
-  list-style: none;
-}
-
 ui5-checkbox {
   -webkit-appearance: checkbox;
 }

diff --git a/src/styles/reset.css b/src/styles/reset.css
@@ -3,7 +3,6 @@
    License: none (public domain)
 */
 
-html,
 ul,
 p {
   margin: 0;
@@ -15,37 +14,14 @@ p {
 }
 
 /* HTML5 display-role reset for older browsers */
-article,
-aside,
-details,
-figcaption,
-figure,
-footer,
-header,
-hgroup,
-menu,
-nav,
-section {
-  display: block;
-}
 body {
   line-height: 1;
 }
-ol,
+
 ul {
   list-style: none;
 }
-blockquote,
-q {
-  quotes: none;
-}
-blockquote:before,
-blockquote:after,
-q:before,
-q:after {
-  content: '';
-  content: none;
-}
+
 table {
   border-collapse: collapse;
   border-spacing: 0;