Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ui5 checkbox #2585

Merged
merged 11 commits into from
Sep 26, 2023
Merged

Ui5 checkbox #2585

merged 11 commits into from
Sep 26, 2023

Conversation

chriskari
Copy link
Contributor

Description

Changes proposed in this pull request:

  • replaced checkboxes with ui5

Related issue(s)

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 21, 2023
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 21, 2023
@chriskari chriskari marked this pull request as ready for review September 21, 2023 09:32
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 21, 2023
@chriskari chriskari mentioned this pull request Sep 21, 2023
Closed
67 tasks
@chriskari
Copy link
Contributor Author

/retest

@mrCherry97 mrCherry97 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2023
mrCherry97
mrCherry97 requested changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@mrCherry97 mrCherry97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it's possible please wait to merge this after ui5-dialogs, because there is a giant refactor and there will be a lot of conflicts, so it will be better to have this PR later

@mrCherry97
Copy link
Contributor

/unhold

@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 22, 2023
@chriskari
Copy link
Contributor Author

/retest

1 similar comment
@chriskari
Copy link
Contributor Author

/retest

@chriskari
Copy link
Contributor Author

/retest

1 similar comment
@chriskari
Copy link
Contributor Author

/retest

mrCherry97
mrCherry97 requested changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@mrCherry97 mrCherry97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check if this is neccesary in index.scss

// override fd-styles for Safari
input[type='checkbox'] {
  -webkit-appearance: checkbox !important;
}

@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 26, 2023
@kyma-bot
Copy link
Contributor

@chriskari: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-busola-lighthouse 8ea23d8 link false /test pull-busola-lighthouse

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyma-bot kyma-bot merged commit 6eedab1 into kyma-project:ui5 Sep 26, 2023
1 check passed
@chriskari chriskari deleted the ui5-checkbox branch November 21, 2023 08:10
kyma-bot pushed a commit that referenced this pull request Nov 23, 2023
@mrCherry97 @akucharska
@chriskari @halamix2
Move busola from fundamental-react to UI5 (#2554)
b32a386 
* ui5 status badge (#2542)

* ui5 status badge

* bump

* bump

* fix jest config

* move JSONSchema

* bump

* Migrate messageBox to webcomponents (#2544)

* Migrate messageBox to webcomponents

* Bump image

* Fix tests

* Fix tests

* Bump image

* Adjust integration tests

* Fix some tests

* Fix some tests

* Fix some tests

* Fix test settings

* Fix incorrect path test

* Fix protected resources tests

* Fix run after tests

* Fix reduced permissions and resource validation

* Fix tests

* Uncomment

* Make timeout longer

* deployments

* Ui5 message strips (#2558)

* replaced notification toast

* replaced MessageStrips

* adjusted extensibility alerts

* bump deployment

* adjusted test-invalid-kubeconfig

* adjuste test & removed unused css

* removed unused css

* fixed invalid-kubeconfig-test

* resolve merge conflicts

* fixed test-resource-validation

* removed unnecessary css

* deploments

* UI5-breadcrumbs (#2560)

* replaced breadcrumbs

* adjustedd pageheadertest

* fixed cluster tests

* fix previous commit

* fix cluster tests

* fix cluster tests

* fix ext-test-services

* fix test-inspect-list

* fix namespace-tests

* clean up of tests-code

* bump deployment

* fixed test issue

* removed includeShadowDom from tests

* fixed tests

* fixed last tests

* bigger timeout on jobs-test

* shellbar ui5 (#2555)

* shellbar ui5

* fix navigation on cluster dropdown, add namespace dropdown menu, cleanup

* move cluster and namespace url to same import

* remove unnecesary onClick

* plus for upload yaml, add button for namespace menu

* namespace dropdown and cluster overview

* Fix height of the navigation in header

* remove addind additional node for cluster overview

* bump

* remove unused imports and code

* fix tests using preferences and feedback

* fix tests

* fix navigation on back to cluster details and tests

* fix no displaying cluster overview and back to cluster on condensed sidenav

* workaround for not to display on cluster view

* remove extensions

* fix tests

* fix tests

* fix cron jobs test

* fix ingresses test

* fix network policies test

* fix PVC test

* fix reduced permissions test

* fix resource upload test

* fix sa test

* fix reduced permissions test

* apply comments

---------

Co-authored-by: Agata Kucharska <agata.kucharska@sap.com>

* Ui5 buttons (#2561)

* replaced buttons 1

* replaced buttons 2

* replaced buttons 3

* bump deployment

* ajusted button icons

* ajusted list action icons

* fix extensibility tests

* fix code-style-issues

* fix cluster tests

* fix namespace tests 1

* fixed cluster tests

* removed compact-property from buttons

* adjusted namespace tests

* adjusted namespace tests

* fix component tests

* fix tests

* increased timeout jobs-test

* fixed lighthouse test

* remove clg

* Horizon theme (#2562)

* first implement of horizon theme

* bump

* fix initTheme

* remove unnecesary function from themeAtom

* change to horizon and fix sidebar width

* change kyma icon

* bump backend

* idk if it's necesary

* fix linking themes

* remove clg

* implement of light_dark automatically adjusted to system pref

* change naming of ligh/dark funtion

* Removed icon on notification message-strip (#2565)

* added hideIcon-flag on notification message-strip

* bump deployment

* hide sidebar-switcher on cluster overview (#2567)

Co-authored-by: Mateusz Wisniewski <mwisnia97@gmail.com>

* ui5-wizards (#2564)

* first move of cluster wizard

* small cleanup

* add functionallity for navigationg next and previous stepremove unnecesady min-height for kubeconfigupload

* make navigation smother and easier to understand

* add reusable WizardButtons component

* move module wizard to ui5

* remove unnecesary csses

* bump

* fix tests and add aria-label to buttons

* fix lighthouse

* fix lighthouse

* fix tests

* fix tests

* fix tests

* fix csses

* fix mobile view upload yaml button css

* Ui5 generic list (#2568)

* Migrate table

* Fix issues with colspan

* Fix in class name

* Bump image

* Small fix

* Fix Table.test.js - searching part

* Fix unit tests

* Fix config maps

* Fix integration tests

* Small fix

* Fix tests

* Fix tests

* Review changes

* Fix test

* Ui5 headers (#2569)

* move resourceList header to ui%

* bump

* fix cypress tests

* fix unit test from #2568

* fix pageheader and resourcenotfound unit tests

* fix tests

* fix cypress tests

* fix cypress tests

* fix cypress tests

---------

Co-authored-by: Agata Kucharska <akucharska@users.noreply.github.com>

* Ui5 panels (#2570)

* move eventDetails, defaultBackendPanel, Rules to ui5 panel

* namespace workloads and resource usage

* move helm release data, helm release data and node machine info to ui5 panel, adjust CSSes

* fix csses and LayoutPanelRow

* move busola extension details panel

* move cluster validation panel

* move resource validation, noderesources and custom resource of type panels

* move curentCRD version panel

* move schema viewer panel and fix displaying text

* move pv and pvc panels

* move labelSelector and network policies panels

* move pod containerData panels

* I'm stupid... Everybody makes mistakes

* move pod logs panel

* move pod template panels

* move sc, certificate and groupListPage panels

* move readOnlyPanel

* move readOnlyEditor, ResourceGraph, ResourceNotFound panels

* first implementation of custom UI5Panel

* add UI5Panel component and refactor

* move some more panels

* remove unused code and move secrets data panel

* move statsPanel panels

* move resourceCommitment panel

* en.yaml

* remove unused collapsiblePanel component

* remove unused skelton component

* move genericlist panels and adjust pagination

* move extensibility Panel widget panel

* move error panel and extensibility error panel

* bump

* fix unit tests

* fix unit tests

* fix unit tests

* fix some of cluster tests

* fix looking for cluster details title

* fix deleteFromGenericlist thanks Agata

* fix changeCluster command and add exception for cypress

* fix namespace tests

* Fix Table tests

* Fix SecretData test

* Fis cluster validation tests

* Rework secretData

* Fix secrets tests

---------

Co-authored-by: Agata Kucharska <agata.kucharska@sap.com>

* Ui5 icons (#2573)

* add csses for icon size and move some icons

* move all icons

* bump

* fix tests

* remove iconGlyph from fundamental

* Ui5 tabs (#2571)

* Tabs

* Fix tabs and tests

* Bump images

* Fix test

* Fix background

---------

Co-authored-by: Mateusz Wisniewski <mwisnia97@gmail.com>

* deployments

* no upload-yaml on noPermissions-view (#2579)

* upload-yaml-button in Shellbar is now hidden on noPermissions-View

* bump deployment

* fix cluster test

* UI5 Tokens (#2578)

* replaced Tokens and adjusted css

* bump deployment

* fix namespace tests

* fix component tests

* remove unnecessary ts-ignore

* replace MessagePage (#2577)

* replaced MessagePage and adjusted css

* replaced KymaModules-MessagePage

* Ui5 switch (#2582)

* replaced switches with ui5

* fixed unit test

* further adjusted unit test

* bump deployment

* removed unused css

* fixed namespace test

* adjusted css

* removed unused file (with old token)

* fix jobs-test

* Ui5 busyindicator (#2575)

* Migrate BusyIndicator

* Remove fd-layout-panel styles

* Bump images

* Fix

* Review fix

---------

Co-authored-by: Mateusz Wisniewski <mwisnia97@gmail.com>

* Fix empty headerActions bug (#2580)

* if headerActions are empty no actions will be displayed now

* bump deployment

* adjusted padding of drag-file-button

* fix jobs-test

---------

Co-authored-by: Agata Kucharska <akucharska@users.noreply.github.com>

* Ui5 PageHeader refactor and dialogs (#2576)

* move add cluster dialog and cleen CSSes

* move cluster validation dialog and fix tests

* move modalWithForm tests are failing

* bump

* blind coding is my passion

* final fix for dialogs

* fix run before test:

* move cluster list and cluster overview content to content of dunamicPage

* refactor of pageHeader

* fix modalWithForm and resourceValidation

* remove unnecesary csses and change initTheme

* move yamlUploadDialog, rename show to open and add to helm releases

* move wizard, preferences and token request

* move error modal

* fix for custom resources

* fix tests, command pallete and resources list

* fix tests, yamlUploadDialog and resource details

* fix the rest of cluster tests

* fix more namespace tests and add padding to incorect path dialog

* move sortModal, fix vertical tabs and fix all of the tests

* remove currently unnecesary css

* Fix preferences tersts

* fix onCancels, reduce permissions tests and deleteMessageBox on ClusterList

* I hope it's finall fix for cypress

* I hope NOW it's finall fix for cypress

* Fix unit test by creating custom query

* Remove force

* rename pageHeader to DynamicPageComponent, fix two more tests

* remove includeShadowDoms and adjust tests

* one more fix

* one more fix

* fix cypress and eslint in tests

* last cypress fix (I pray for that)

* last cypress fix (I pray for that one more time)

* last cypress fix (I pray for that one more time second time)

* remove unused props and csses

---------

Co-authored-by: Agata Kucharska <agata.kucharska@sap.com>

* Ui5 textarea (#2590)

* Remove unused files

* Migrate textarea

* Bump images

* Fix tests

* Update src/shared/ResourceForm/fields/DataField.js

Co-authored-by: Mateusz Wisniewski <mwisnia97@gmail.com>

* prettier

---------

Co-authored-by: Mateusz Wisniewski <mwisnia97@gmail.com>

* Ui5 checkbox (#2585)

* bump deployment

* replaced checkboxes with ui5

* fix tests

* removed unused argument

* small style adjustment

* fix tests

* removed unused css styling

* adjusted css stylingg

---------

Co-authored-by: Mateusz Wisniewski <mwisnia97@gmail.com>

* Ui5 select (#2589)

* replaced select in preferences

* replaced further select elements

* added selected-property to options

* replaced Select elements with ui5 combobox

* disabled typing on combobox

* fixed read-only bug

* adjusted components

* fix form-validation bug and cluster tests

* fixed tests

* removed unused css

* fixed namespace tests

* fixed jobs test

* fixed issues

* deployments

* fix types of badges (#2597)

* fix types of badges

* bump

* fix types of badges

* fix tests

* fix tests

* add warning to cases

* fix docs

* fix tests

* I hope this is last fix

* UI5-combobox (#2600)

* replaced comboboxes

* bump deployment

* replaced comboboxes

* adjusted css

* removed unused css

* fixed cluster tests

* fixed issues with combobox array input

* fixed selection change bug

* Use chromium (#2601)

* Try using chromium

* fix local

* adjust changes

---------

Co-authored-by: Piotr Halama <piotr.halama@sap.com>
Co-authored-by: mrCherry97 <mwisnia97@gmail.com>

* Update webcomponents to latest (#2598)

* update webcomponents to latest

* bumps

* fix unit tests

* fix unit tests

* potenital fix of Namespacesettings unit test

* Use chromium (#2601)

* Try using chromium

* fix local

* fix unit tests

* fix jobs test

---------

Co-authored-by: chriskari <chriskari@gmx.de>
Co-authored-by: Piotr Halama <piotr.halama@sap.com>

* UI5 styling and bugfixes (#2603)

* adjusted styling of message strips in editor

* adjusted styling of deleteResourceMessageBox

* bump deployment

* fixed double label bug in simple list

* styled pod-restarts badge

* fixed styling of metrics-graph-dropdown

* used flexbox instead of div

* improve mobile view (#2608)

* fixed mobile styling of preferences dialog

* bump deployment

* adjusted page header

* Namespace workloads

* adjusted statsgraph

* added external link icon

* ui5 Forms (#2602)

* move some formInputs

* move more formInputs

* big big problem

* remove csses = some sort of solution

* Kinda fix layout

* Fix readOnly option and fix some displaying

* Fix broken forms

* Fix styling of RoleBindings

* Migrate from fd-row in Form field

* Migrate from fd-row in Simple List and MultiInput

* Remove unused imports

* Remove unused component LabelSelectorInput

* Remove unused component TextFormItem

* Replace FormLabel

* migrated inputgroup

* Fix API Rules

* Get rid of FormLabel and FormFieldset

* Fix comandPallete

* Small fix

* Bump web image

* Partially fix cluster role binding tests

* Fix cluster role binding tests

* Autofocus commandPalette

* Migrate search input

* Fix command palette tests

* We can not set UI5Input in jest, remove connected tests

* Small fixes

* We can not set UI5Input in jest, remove connected tests

* Review fixes

* Apply suggestions from code review

Co-authored-by: Mateusz Wisniewski <mwisnia97@gmail.com>

* Small fix

* Fix search

* Fix test-navigation-features test

* Fix searching

* Fix pizzas and some tests

* Fix test variables

* Fix input number and some tests

* Fix tests and displaying longer forms

* Fix tests

* Fix tests

* Review changes to ariaLabel

* Fix protected resources

* Fix tests

* Remove unused files

* Fix failing tests

* Fix extension creation form

* Change readOnly on disabled

* Fixes

* Fixes

* Fix create Namespace

* Fixes

* Fixes

* Remove change

---------

Co-authored-by: Agata Kucharska <agata.kucharska@sap.com>
Co-authored-by: chriskari <chriskari@gmx.de>
Co-authored-by: Agata Kucharska <akucharska@users.noreply.github.com>

* move infoLabel and menus (#2614)

* move infoLabel

* remove unnecesary customResources and move menu from listActions

* search menu, but not working

* fix search

* fix search

* bump

* fix tests

* fix deleteFromGenericlist

* hopefully finall fix for search

* remove unused className

* fix modules widget

* fix tests

* trying to fix tests

* trying to fix tests one more time

* UI5-Radiobutton (#2620)

* formRadiogroup in choose-storage

* formRadiogroup in checkboxes

* formRadiogroup in sortmodalpanel

* ajdusted cluster tests and removed unused vars

* removed part of test that wouldn't pass

* removed unused code

* added sort-functionality to tests

* fix random fail of namespace tests

---------

Co-authored-by: Mateusz Wisniewski <mwisnia97@gmail.com>

* Fix multi input (#2629)

* Remove obsolete styles

* Fix keyValuPair and MultiInput

* Bump images

---------

Co-authored-by: Mateusz Wisniewski <mwisnia97@gmail.com>

* remove fundamental-react/styles and fix uuid for backend (#2630)

* remove fundamental-react/styles and fix uuid for backend

* bumps

* Styles refactor (#2631)

* fix links styles and rename from fd-link to bls-link

* cleanup and rename fd- to bsl-

* refactor of margin styles

* fix stats panel for CPU usage on cluster overview

* change fd-has to bsl-has

* remove fd-shellbar

* rename ariaLabel to aria-label

* bump

* Fix custom form-validation (#2628)

* fixed validation of comboboxes

* bump deployment

* fixed validateFormField and validateInputList

* added validate MultCheckboxes

* fixed validation of multi-inputs

* removed console logs

* fix tests

* fix random test fail

* fix validation for both extensibility and js formsm

* instant value-updates for comboboxes & inputs (#2635)

* comboboxes now instantly update the value (some excluded)

* bump deployment

* added onInput for inputs

* added validateKeyValuePair to customFormValidation

* fixed reduced-permissions-test

* maybe fix random fail of namespace-overview-test

* maybe fix random fail of pasteToMonaco

* fixed onInput functionality for KeyValuePairs

* fixed test-protected-resources

* further stabilized test-reduced-permissions

* further stabilized test-reduced-permissions

* small onInput adjustment

* Fix forms (#2639)

* introduce fd cann and rename to bsl

* rename fd-col to bsl-col

* remove unused fd-row

* bump

* Update src/shared/ResourceForm/fields/MultiInput.js

Co-authored-by: Agata Kucharska <akucharska@users.noreply.github.com>

* fix lint

---------

Co-authored-by: Agata Kucharska <akucharska@users.noreply.github.com>

* Fix ui5 sidenavigation2 (#2643)

* Move footer to fixed items

* Css apocalyse

* Fix layout

* Fix shellbar in navigation

* Bump images

* Remove unused stuff

* Fix shadow on nested navigation

* Hide scroll bar, fix some css's

* Adjust logo

* fix Cluster List

* Fix shadow in navogation, margins in generic list

* Review changes

* Fix busola version test

* Apply suggestions from code review

Co-authored-by: Mateusz Wisniewski <mwisnia97@gmail.com>

* Review changes

* Revert "Apply suggestions from code review"

This reverts commit 22331c1.

---------

Co-authored-by: Mateusz Wisniewski <mwisnia97@gmail.com>

* Public utils (#2642)

* add public utils for spacing

* adjust magins for extensions details

* remove deprecated toolbarspacer from extensions

* margin refactor

* margin refactor

* pray to god, that everything is working

* bump

* bump

* fix version of packages

* adjust margins after merged changes

* Fix error boundary component (#2644)

* fix error boundary component

* remove unused css

* bump

* fix some things

* fix some things

* bring back visible:

* bring back visible

* scrollBehavior

* maybe I'm really stupid

* fix

* trying to prevent random failing

* fix cron job test

* fix tests

* dump problem...

* adjust create-form (#2646)

* adjusted yaml-editor size

* fixed scroll-bug in create-extension

* bump deployment

* adjusted yaml-editor size

---------

Co-authored-by: Mateusz Wisniewski <mwisnia97@gmail.com>

* Firefox safari (#2645)

* Fix font in button on firefox and safari

* Bump images

---------

Co-authored-by: Mateusz Wisniewski <mwisnia97@gmail.com>

* ux-compliance (#2647)

* changed external link icon

* bump deployment

* changed upload-button text

* adjusted event-type-icon

* changed design of delete-buttons

* changed delete-Resource title

* changed link-icons

* fixed tests: delete Resource

* fixed tests: delete Resource (from GenericList)

* fixed upload-tests

* fixed delete-tests

* fixed delete-tests

* stabilized roles-test

---------

Co-authored-by: Mateusz Wisniewski <mwisnia97@gmail.com>

* Ui5 fix margins (#2648)

* Fix margins on details pages, fix tabs

* Bump images

* Fix icons in forms

---------

Co-authored-by: Mateusz Wisniewski <mwisnia97@gmail.com>

* Bump images

* Edit-Cluster style & CSS refactor (#2649)

* adjusted margins for edit-cluster

* bump deployment

* removed css: create-resource-modal

* adjusted styling of kubeconfigupload

* removed unused css

* removed unused css

* removed unused css & code clean up

* removed & adjusted css

* removed css & ajusted tests

* removed leftover fundamental-css

* simple list & multi input adjustments

* spacing in contentwrapper

* removed duplicate code: MemoryInput

* fixed test-cluster-validation

* bump

---------

Co-authored-by: Agata Kucharska <akucharska@users.noreply.github.com>
Co-authored-by: Christian Karidas <105549337+chriskari@users.noreply.github.com>
Co-authored-by: Agata Kucharska <agata.kucharska@sap.com>
Co-authored-by: Piotr Halama <piotr.halama@sap.com>
Co-authored-by: chriskari <chriskari@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrCherry97 mrCherry97 mrCherry97 approved these changes

@akucharska akucharska Awaiting requested review from akucharska

@valentinvieriu valentinvieriu Awaiting requested review from valentinvieriu

Assignees

@mrCherry97 mrCherry97

Labels
lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chriskari @kyma-bot @mrCherry97