Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add separate GHAction for lint check #3052

Merged
merged 17 commits into from
Jul 12, 2024
1 change: 0 additions & 1 deletion .github/workflows/busola-local-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ on:
- "package.json"
- "Makefile"
- "Dockerfile.local"
- "docs/**"

permissions:
id-token: write # This is required for requesting the JWT token
Expand Down
20 changes: 20 additions & 0 deletions .github/workflows/lint-check-pr.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
name: PR Lint Check

on:
pull_request:
types: [opened, edited, synchronize, reopened, ready_for_review]

jobs:
run-lint-check:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0
- name: lint_check
shell: bash
run: |
set -e
npm ci
npx eslint --max-warnings 0 src/ backend/
npm run lint-check
1 change: 1 addition & 0 deletions src/shared/components/__mocks__/popper.js.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
const PopperJS = jest.requireActual('popper.js');

/* eslint-disable import/no-anonymous-default-export */
export default class {
static placements = PopperJS.placements;

Expand Down
Loading