Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix footer position #3056

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Fix footer position #3056

merged 3 commits into from
Jul 12, 2024

Conversation

dbadura
Copy link
Contributor

@dbadura dbadura commented Jul 10, 2024

Description

Changes proposed in this pull request:

  • Force footer to be at the bottom

Related issue(s)

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 10, 2024
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 10, 2024
@dbadura dbadura marked this pull request as ready for review July 11, 2024 11:21
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2024
@dbadura dbadura linked an issue Jul 11, 2024 that may be closed by this pull request
Margin for cards in modules and footer adjustments #3035
Closed
2 tasks
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 12, 2024
@kyma-bot kyma-bot merged commit c8f692d into kyma-project:main Jul 12, 2024
11 checks passed
@dbadura dbadura deleted the fix-footer-position branch July 12, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskari chriskari chriskari approved these changes

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@mrCherry97 mrCherry97 Awaiting requested review from mrCherry97 mrCherry97 is a code owner

@valentinvieriu valentinvieriu Awaiting requested review from valentinvieriu

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

Assignees

@chriskari chriskari

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Margin for cards in modules and footer adjustments
3 participants
@dbadura @kyma-bot @chriskari