Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: take module state from module instead of kyma CR #3061

Merged
merged 5 commits into from
Jul 15, 2024
Merged

feat: take module state from module instead of kyma CR #3061

merged 5 commits into from
Jul 15, 2024

Conversation

mrCherry97
Copy link
Contributor

@mrCherry97 mrCherry97 commented Jul 12, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • feat: take module state from module instead of kyma CR

Related issue(s)
Closes #3040

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 12, 2024
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 12, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 12, 2024
@mrCherry97 mrCherry97 changed the title Modules statuses feat: take module state from module instead of kyma CR Jul 12, 2024
@mrCherry97 mrCherry97 marked this pull request as ready for review July 12, 2024 12:49
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 12, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 15, 2024
@kyma-bot kyma-bot merged commit a0936e0 into kyma-project:main Jul 15, 2024
49 of 54 checks passed
@mrCherry97 mrCherry97 deleted the modules-statuses branch July 15, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskari chriskari chriskari approved these changes

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@valentinvieriu valentinvieriu Awaiting requested review from valentinvieriu

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

Assignees

@chriskari chriskari

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

State of the module in the list of the modules view should be taken from Module not from the Kyma CR
4 participants
@mrCherry97 @kyma-bot @chriskari @akucharska