Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cursor pointer on GenericList #3085

Merged
merged 2 commits into from
Jul 22, 2024
Merged

fix: cursor pointer on GenericList #3085

merged 2 commits into from
Jul 22, 2024

Conversation

mrCherry97
Copy link
Contributor

@mrCherry97 mrCherry97 commented Jul 18, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • add cursor pointer CSSes
  • fix setting up a className

Related issue(s)
See also #3011

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 18, 2024
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@mrCherry97 mrCherry97 marked this pull request as ready for review July 18, 2024 12:04
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 18, 2024
@akucharska akucharska self-assigned this Jul 19, 2024
@mrCherry97 mrCherry97 mentioned this pull request Jul 19, 2024
Closed
5 tasks
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 22, 2024
@mrCherry97
Copy link
Contributor Author

/retest

1 similar comment
@mrCherry97
Copy link
Contributor Author

/retest

@kyma-bot kyma-bot merged commit 02b2e20 into kyma-project:main Jul 22, 2024
26 of 27 checks passed
@mrCherry97 mrCherry97 deleted the fix-cursor-pointer branch July 22, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akucharska akucharska akucharska approved these changes

@valentinvieriu valentinvieriu Awaiting requested review from valentinvieriu

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

Assignees

@akucharska akucharska

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrCherry97 @kyma-bot @akucharska