Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add view allows only adding the modules #3094

Merged
merged 5 commits into from
Jul 30, 2024
Merged

feat: Add view allows only adding the modules #3094

merged 5 commits into from
Jul 30, 2024

Conversation

OliwiaGowor
Copy link
Contributor

@OliwiaGowor OliwiaGowor commented Jul 24, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • add view allows only adding the modules
  • added additional info when all modules are installed

Related issue(s)
#3076

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2024
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 24, 2024
@kyma-bot kyma-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 24, 2024
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 24, 2024
@OliwiaGowor OliwiaGowor linked an issue Jul 24, 2024 that may be closed by this pull request
Modules: Add view should allow only adding the modules #3076
Closed
6 tasks
@mrCherry97 mrCherry97 self-assigned this Jul 30, 2024
@OliwiaGowor OliwiaGowor marked this pull request as ready for review July 30, 2024 11:04
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 30, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 30, 2024
@kyma-bot kyma-bot merged commit 665785d into kyma-project:main Jul 30, 2024
25 of 26 checks passed
@OliwiaGowor OliwiaGowor deleted the only-adding-modules branch September 16, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IwonaLanger IwonaLanger IwonaLanger approved these changes

@mrCherry97 mrCherry97 mrCherry97 approved these changes

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@valentinvieriu valentinvieriu Awaiting requested review from valentinvieriu

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

Assignees

@mrCherry97 mrCherry97

@IwonaLanger IwonaLanger

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modules: Add view should allow only adding the modules
4 participants
@OliwiaGowor @kyma-bot @mrCherry97 @IwonaLanger