Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Edit module #3098

Merged
merged 5 commits into from
Jul 30, 2024
Merged

feat: Edit module #3098

merged 5 commits into from
Jul 30, 2024

Conversation

akucharska
Copy link
Contributor

@akucharska akucharska commented Jul 26, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • add edit form
  • show confirmation when saved (only once)

Related issue(s)

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 26, 2024
@akucharska akucharska linked an issue Jul 26, 2024 that may be closed by this pull request
Modules: Edit view in Modules should have a form that changes the modules channel #3077
Closed
10 tasks
@OliwiaGowor OliwiaGowor self-assigned this Jul 29, 2024
mmitoraj
mmitoraj previously approved these changes Jul 29, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 29, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jul 29, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 30, 2024
@kyma-bot kyma-bot merged commit 14c43c0 into kyma-project:main Jul 30, 2024
13 checks passed
@mrCherry97 mrCherry97 deleted the edit-module branch July 30, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OliwiaGowor OliwiaGowor OliwiaGowor approved these changes

@mmitoraj mmitoraj mmitoraj approved these changes

@mrCherry97 mrCherry97 Awaiting requested review from mrCherry97 mrCherry97 is a code owner

@valentinvieriu valentinvieriu Awaiting requested review from valentinvieriu

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

Assignees

@mmitoraj mmitoraj

@OliwiaGowor OliwiaGowor

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modules: Edit view in Modules should have a form that changes the modules channel
4 participants
@akucharska @mmitoraj @OliwiaGowor @kyma-bot