-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add statusBadge for extensibility #3099
Merged
kyma-bot
merged 5 commits into
kyma-project:main
from
OliwiaGowor:add-statusBadge-extensibility
Jul 29, 2024
Merged
feat: Add statusBadge for extensibility #3099
kyma-bot
merged 5 commits into
kyma-project:main
from
OliwiaGowor:add-statusBadge-extensibility
Jul 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Jul 29, 2024
Skipping CI for Draft Pull Request. |
kyma-bot
added
cla: yes
Indicates the PR's author has signed the CLA.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Jul 29, 2024
OliwiaGowor
requested review from
a team,
akucharska,
mrCherry97,
valentinvieriu and
chriskari
as code owners
July 29, 2024 08:02
kyma-bot
removed
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Jul 29, 2024
OliwiaGowor
commented
Jul 29, 2024
grego952
reviewed
Jul 29, 2024
@@ -8,7 +8,7 @@ In the **data.details** section you can provide configuration of four optional c | |||
|
|||
### **header**, **status**, **body** and **health** Parameters | |||
|
|||
This table lists the available parameters of the **data.details.header**, **data.details.status**, **data.details.health** and/or **data.details.body** section in your resource ConfigMap. You can learn whether each of the parameters is required and what purpose it serves. The **data.details.header**, **data.details.status**, **data.details.health** and **data.details.body** components are arrays of objects. | |||
This table lists the available parameters of the **data.details.header**, **data.details.status**, **data.details.health** and/or **data.details.body** section in your resource ConfigMap. You can learn whether each of the parameters is required and what purpose it serves. The **data.details.header**, **data.details.health** and **data.details.body** components are arrays of objects. The **data.details.status** component is an object that accepts **header** and **details** parameters. Within **data.details.status**, the **header** component is an object, and the **details** component is an array of objects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
This table lists the available parameters of the **data.details.header**, **data.details.status**, **data.details.health** and/or **data.details.body** section in your resource ConfigMap. You can learn whether each of the parameters is required and what purpose it serves. The **data.details.header**, **data.details.health** and **data.details.body** components are arrays of objects. The **data.details.status** component is an object that accepts **header** and **details** parameters. Within **data.details.status**, the **header** component is an object, and the **details** component is an array of objects. | |
This table lists the available parameters of the **data.details.header**, **data.details.status**, **data.details.health** and/or **data.details.body** section in your resource ConfigMap. You can learn whether each of the parameters is required and what purpose it serves. The **data.details.header**, **data.details.health** and **data.details.body** components are arrays of objects. The **data.details.status** component is an object that accepts the **header** and **details** parameters. Within **data.details.status**, the **header** component is an object, and the **details** component is an array of objects. |
grego952
approved these changes
Jul 29, 2024
mrCherry97
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
#3070
Definition of done
backlog#4567