Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: always request openid scope from idp #3289

Closed
wants to merge 1 commit into from
Closed

fix: always request openid scope from idp #3289

wants to merge 1 commit into from

Conversation

v0lkc
Copy link
Contributor

@v0lkc v0lkc commented Aug 22, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • busola shall always request the openid scope

Related issue(s)

#3288

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • [ x Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 22, 2024
@kyma-bot
Copy link
Contributor

Hi @v0lkc. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 22, 2024
@v0lkc v0lkc changed the title fix: login issue when are present in the kubeconfig fix: login issue when --oidc-extra-scope args are present in the kubeconfig Aug 22, 2024
@v0lkc

This comment was marked as outdated.

Sign in to view
@kyma-bot
Copy link
Contributor

@v0lkc: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@v0lkc v0lkc changed the title fix: login issue when --oidc-extra-scope args are present in the kubeconfig fix: always request openid scope from idp Aug 22, 2024
@v0lkc
Copy link
Contributor Author

v0lkc commented Aug 22, 2024

@mrCherry97 could you please have a look?

@v0lkc
Copy link
Contributor Author

v0lkc commented Aug 26, 2024

Closing, in favor of #3209

@v0lkc v0lkc closed this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@mrCherry97 mrCherry97 Awaiting requested review from mrCherry97 mrCherry97 is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

Assignees
No one assigned
Labels
cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v0lkc @kyma-bot