Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disableOnEdit KeyValuePair #3316

Merged
merged 8 commits into from
Sep 17, 2024

Conversation

kevin-kho
Copy link
Contributor

@kevin-kho kevin-kho commented Aug 28, 2024

Description

Changes proposed in this pull request:

  • disableOnEdit feature for KeyValuePair widget
  • documentation for the new disableOnEdit

Related issue(s)

Fixes #3315

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 28, 2024
@kevin-kho kevin-kho force-pushed the kh-kvp-disableOnEdit branch from 624e82a to ed32afc Compare September 4, 2024 18:09
@kevin-kho kevin-kho requested a review from dbadura as a code owner September 4, 2024 18:09
@kevin-kho kevin-kho force-pushed the kh-kvp-disableOnEdit branch 2 times, most recently from d934618 to c00bab2 Compare September 9, 2024 16:16
akucharska
akucharska previously approved these changes Sep 13, 2024
Copy link
Contributor

@akucharska akucharska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution

@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 13, 2024
docs/extensibility/60-form-widgets.md Outdated Show resolved Hide resolved
public/schemas/schema-form.yaml Outdated Show resolved Hide resolved
Co-authored-by: Natalia Sitko <80401180+nataliasitko@users.noreply.github.com>
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Sep 16, 2024
Co-authored-by: Natalia Sitko <80401180+nataliasitko@users.noreply.github.com>
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 17, 2024
@kyma-bot kyma-bot merged commit c95b243 into kyma-project:main Sep 17, 2024
17 checks passed
@kevin-kho kevin-kho deleted the kh-kvp-disableOnEdit branch September 18, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disableOnEdit for KeyValuePair widgets
4 participants