Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add long columns in status card #3324

Merged
merged 3 commits into from
Sep 5, 2024
Merged

feat: Add long columns in status card #3324

merged 3 commits into from
Sep 5, 2024

Conversation

akucharska
Copy link
Contributor

@akucharska akucharska commented Sep 3, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Add long columns in status card

Related issue(s)

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 3, 2024
@OliwiaGowor OliwiaGowor mentioned this pull request Sep 3, 2024
Merged
4 tasks
@akucharska akucharska requested a review from a team as a code owner September 4, 2024 06:38
@akucharska akucharska linked an issue Sep 4, 2024 that may be closed by this pull request
Enhance DNS Entries #3326
Closed
3 tasks
@OliwiaGowor OliwiaGowor self-assigned this Sep 4, 2024
OliwiaGowor
OliwiaGowor reviewed Sep 4, 2024
View reviewed changes
Copy link
Contributor

@OliwiaGowor OliwiaGowor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renaming proposition: customColumnsFullWidth/fullWidth

@mrCherry97
Copy link
Contributor

my proposal: maybe we can remove the type property and change it to fullWidth: true

@akucharska akucharska requested a review from dbadura as a code owner September 5, 2024 08:59
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 5, 2024
@kyma-bot kyma-bot merged commit f87fc8b into kyma-project:main Sep 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IwonaLanger IwonaLanger IwonaLanger approved these changes

@OliwiaGowor OliwiaGowor OliwiaGowor approved these changes

@mrCherry97 mrCherry97 Awaiting requested review from mrCherry97 mrCherry97 is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

Assignees

@OliwiaGowor OliwiaGowor

@IwonaLanger IwonaLanger

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance DNS Entries
5 participants
@akucharska @mrCherry97 @OliwiaGowor @IwonaLanger @kyma-bot