-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: change CRA to Vite #3334
Conversation
Skipping CI for Draft Pull Request. |
…ix EditCluster, add plugin for paths and svgs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's left/need to be checked:
- Cypress is working, but can't connect to the cluster (looks like frontend - backend connection is not working
- Unit testes need to be adjusted (Jest and react-testing-library)
- After running first time the app, there is some random refresh, need to be checked on the build version (run docker image from PR or
npm run build && serve -d
- monaco worker has some problem (need to be fixed or open an issue for follow up)
- need to run docker image from PR (local, web) and check that everything is working corectly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion it looks good
Description
Changes proposed in this pull request:
import * as jp
->import jp
build
command withNODE_OPTIONS
import.meta.env.PUBLIC_URL
toBASE_URL
IS_DOCKER
variableRelated issue(s)
Closes #3062
Definition of done
backlog#4567