feat: Create release process #3485
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
the
size/L
4 tasks
dbadura
requested review from
akucharska,
mrCherry97,
chriskari and
OliwiaGowor
as code owners
kyma-bot
removed
the
do-not-merge/work-in-progress
dbadura
added
the
do-not-merge/work-in-progress
dbadura
removed
the
do-not-merge/work-in-progress
mrCherry97
requested changes
Nov 22, 2024
Comment on lines
28
to
30
| context: backend | ||
| export-tags: true | ||
| tags: latest |
There was a problem hiding this comment.
make sure that we can remove this
There was a problem hiding this comment.
export-tags is not needed in my opinion. According to docs:
description: Export parsed tags as build-args into dockerfile. Each tag will have format TAG_x, where x is the tag name passed along with the tag
I think that it's unnecessary complication and it hides the build logic.
| export-tags: true | ||
| tags: latest | ||
| tags: ${{ inputs.tag != '' && inputs.tag || 'latest' }} | ||
| build-args: ${{ inputs.tag != '' && format('tag={0}', inputs.tag) || '' }} |
There was a problem hiding this comment.
Make sure after first release on dev, that it is working and displayed correctly
.github/workflows/create-release.yml
Outdated
Comment on lines
31
to
36
| # integrations: | ||
| # needs: create-draft | ||
| # secrets: inherit | ||
| # uses: ./.github/workflows/_integration-tests.yaml | ||
| # with: | ||
| # image: europe-docker.pkg.dev/kyma-project/prod/serverless-operator:${{ github.event.inputs.name }} |
There was a problem hiding this comment.
remove it for now, will be done in separate task
.github/workflows/create-release.yml
Outdated
| # needs: upgrade-images | ||
| create-release: | ||
| name: Create release | ||
| needs: [ build-web, build-backend ] |
There was a problem hiding this comment.
Suggested change
| needs: [ build-web, build-backend ] | |
| needs: [ build-web, build-backend, build-local ] |
Comment on lines
46
to
+47
| fetch-depth: 0 | ||
| ref: ${{ github.ref_name }} # Checkout to latest branch changes | ||
| ref: ${{ github.ref_name }} # checkout to latest branch changes ( by default this action checkouts to the SHA that triggers action ) |
There was a problem hiding this comment.
Check if this fetch-depth is needed
There was a problem hiding this comment.
Yes, according to docs:
# Number of commits to fetch. 0 indicates all history for all branches and tags.
# Default: 1
fetch-depth: ''
```
If we want to create changelog, it's needed
| @@ -15,7 +16,7 @@ ENV CI true | |||
|
|
|||
| COPY . /app | |||
|
|
|||
| RUN yq -i '.version = "'${default_tag}'"' public/version.yaml && \ | |||
| RUN export TAG=${tag:-$default_tag} && yq -i '.version = "'${TAG}'"' public/version.yaml && \ | |||
There was a problem hiding this comment.
Add some comment to clarify what's going on
Comment on lines
+20
to
+22
|
|
||
| envsubst < "${TMP_DIR}"/ingress/ingress.tpl.yaml > "${TMP_DIR}"/ingress/ingress.yaml | ||
| kubectl apply -k "${TMP_DIR}"/ingress --namespace=$NAMESPACE |
There was a problem hiding this comment.
Will be changed with #3493
4 tasks
mrCherry97
reviewed
Nov 25, 2024
mrCherry97
requested changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
Definition of done
backlog#4567Releasing with semantic versioning #3375