Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Chrome tooltip overlays dropdown options #3546

Merged
merged 2 commits into from
Dec 20, 2024
Merged

fix: Chrome tooltip overlays dropdown options #3546

merged 2 commits into from
Dec 20, 2024

Conversation

KonradPietocha
Copy link
Contributor

@KonradPietocha KonradPietocha commented Dec 18, 2024 •
edited
Loading

…y for widgets

Description

Changes proposed in this pull request:

  • Disable autocomplete for dropdown input,
  • Open select options when click on input
  • Added missing key for widgets

Related issue(s)
fixed #3515

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 18, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 20, 2024
@akucharska akucharska added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2024
@KonradPietocha KonradPietocha changed the title Chrome tooltip overlays dropdown options fix: Chrome tooltip overlays dropdown options Dec 20, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Dec 20, 2024
@kyma-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@akucharska akucharska added lgtm Looks good to me! and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 20, 2024
@KonradPietocha KonradPietocha merged commit 6aaf05f into kyma-project:main Dec 20, 2024
15 checks passed
@KonradPietocha KonradPietocha deleted the chrome-tooltip-overlays-options-3515 branch December 20, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akucharska akucharska akucharska approved these changes

@mrCherry97 mrCherry97 Awaiting requested review from mrCherry97 mrCherry97 is a code owner

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

Assignees

@akucharska akucharska

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chrome tooltip overlays dropdown options
3 participants
@KonradPietocha @kyma-bot @akucharska