Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add documentation about busola in k8s and adjust k8s configs #3547

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

feat: Add documentation about busola in k8s and adjust k8s configs #3547

wants to merge 34 commits into from

Conversation

dbadura
Copy link
Contributor

@dbadura dbadura commented Dec 18, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • adjust k8s resources
  • add docs how to deploy busola on k8s and access it in different scenarios

Related issue(s)

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

#3375

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 18, 2024
@dbadura dbadura force-pushed the busola-k8s branch 2 times, most recently from 30debff to b19a45c Compare December 18, 2024 12:51
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 30, 2024
@dbadura dbadura marked this pull request as ready for review December 31, 2024 14:13
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 31, 2024
@dbadura dbadura added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 31, 2024
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 2, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 8, 2025
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jan 8, 2025
grego952
grego952 reviewed Jan 8, 2025
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated
(cd resources && kubectl apply -f ingress/ingress.yaml)
```

2. Go to `localhost`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I think of it. What does it mean?
Go to the localhost folder? Something else?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated
To be able to connect to the same K3d cluster where Busola is installed.
Download kubeconfig and change cluster server address to `https://kubernetes.default.svc:443`.

Using shell.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To do what? Maybe we don't need this sentence.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@dbadura @grego952
Apply suggestions from code review
0ce0f6c 
Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>
grego952
grego952 reviewed Jan 8, 2025
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
pbochynski
pbochynski previously approved these changes Jan 8, 2025
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 8, 2025
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jan 8, 2025
grego952
grego952 reviewed Jan 8, 2025
View reviewed changes
README.md Outdated Show resolved Hide resolved
grego952
grego952 previously approved these changes Jan 8, 2025
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 8, 2025
pbochynski
pbochynski previously approved these changes Jan 8, 2025
View reviewed changes
@dbadura dbadura dismissed stale reviews from pbochynski and grego952 via a26faa2 January 8, 2025 14:33
@kyma-bot
Copy link
Contributor

kyma-bot commented Jan 8, 2025

New changes are detected. LGTM label has been removed.

@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akucharska akucharska akucharska left review comments

@grego952 grego952 grego952 left review comments

@pbochynski pbochynski pbochynski left review comments

@mrCherry97 mrCherry97 Awaiting requested review from mrCherry97 mrCherry97 is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@pbochynski pbochynski

@grego952 grego952

Labels
cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Releasing with semantic versioning
6 participants
@dbadura @kyma-bot @pbochynski @akucharska @grego952 @mrCherry97