Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate UI5 vitest unit tests to cypress component tests #3551

Merged
merged 44 commits into from
Dec 30, 2024

Conversation

chriskari
Copy link
Contributor

@chriskari chriskari commented Dec 19, 2024

Description

Changes proposed in this pull request:

  • UI5 components need a proper browser environment to be tested -> move all vitest unit tests of components relying on UI5 components to cypress component tests
  • For some vitest unit tests it was sufficient to mock the ui5 dependencies as the focus was not on the component but some functionality
  • Some unit tests test pure javascript functionality and could remain untouched
  • adjust github actions workflow
  • adjusted testing strategy markdowns

Related issue(s)

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 19, 2024
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 19, 2024
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 19, 2024
@chriskari chriskari changed the title feat: migrate UI5 component unit tests to cypress component tests feat: migrate UI5 vitest unit tests to cypress component tests Dec 20, 2024
@chriskari chriskari requested a review from a team as a code owner December 27, 2024 16:34
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 30, 2024
Co-authored-by: Iwona Langer <iwona.langer@sap.com>
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Dec 30, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 30, 2024
@OliwiaGowor OliwiaGowor merged commit 16c7efb into kyma-project:ui5-migrate-v2 Dec 30, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants