Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Modules docs url #3556

Merged
merged 4 commits into from
Dec 27, 2024
Merged

Conversation

akucharska
Copy link
Contributor

@akucharska akucharska commented Dec 23, 2024

Description

Changes proposed in this pull request:

  • Display documentation URL from spec.info
  • Find proper module on list
  • Fix keys in dropdowns (add and edit modules)

Related issue(s)

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 23, 2024
@akucharska akucharska linked an issue Dec 23, 2024 that may be closed by this pull request
4 tasks
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 23, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 24, 2024
@mrCherry97
Copy link
Contributor

/oberride tide

@mrCherry97
Copy link
Contributor

/override tide

@kyma-bot
Copy link
Contributor

@mrCherry97: Overrode contexts on behalf of mrCherry97: tide

In response to this:

/override tide

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mrCherry97 mrCherry97 merged commit 29097a4 into kyma-project:main Dec 27, 2024
15 checks passed
@mrCherry97 mrCherry97 deleted the modules-docs-url branch December 27, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust documentation link for Modules to latest ModuleCatalog changes
4 participants