Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: theme not working properly on initial render and after refresh #3565

Merged
merged 1 commit into from
Jan 2, 2025
Merged

fix: theme not working properly on initial render and after refresh #3565

merged 1 commit into from
Jan 2, 2025

Conversation

OliwiaGowor
Copy link
Contributor

@OliwiaGowor OliwiaGowor commented Dec 31, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • fixed theme not working properly on initial render and after refresh

Related issue(s)
#3422

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 31, 2024
@OliwiaGowor OliwiaGowor mentioned this pull request Dec 31, 2024
Open
@OliwiaGowor OliwiaGowor marked this pull request as ready for review December 31, 2024 12:56
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 31, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 2, 2025
@mrCherry97 mrCherry97 merged commit 0bace38 into kyma-project:ui5-migrate-v2 Jan 2, 2025
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akucharska akucharska akucharska approved these changes

@mrCherry97 mrCherry97 Awaiting requested review from mrCherry97 mrCherry97 is a code owner

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

Assignees

@akucharska akucharska

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OliwiaGowor @akucharska @kyma-bot @mrCherry97