Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changes managed-by label from lifecycle-manager to infrastructure-manager #114

Merged
merged 1 commit into from
Dec 28, 2023
Merged

changes managed-by label from lifecycle-manager to infrastructure-manager #114

merged 1 commit into from
Dec 28, 2023

Conversation

Disper
Copy link
Member

@Disper Disper commented Dec 28, 2023 •
edited
Loading

Description

Secrets are now managed by infrastructure-manager, the corresponding label should reflect that

Changes proposed in this pull request:

  • changes managed-by label from lifecycle-manager to infrastructure-manager.
  • ...
  • ...

Related issue(s)

@Disper Disper requested a review from a team as a code owner December 28, 2023 09:47
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 28, 2023
koala7659
koala7659 approved these changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@koala7659 koala7659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 28, 2023
@kyma-bot kyma-bot merged commit 77f253a into kyma-project:main Dec 28, 2023
7 checks passed
@Disper Disper deleted the managed-by-im branch December 28, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koala7659 koala7659 koala7659 approved these changes

Assignees

@koala7659 koala7659

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Disper @koala7659 @kyma-bot