Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust configuration for metrics #115

Merged
merged 2 commits into from
Dec 29, 2023
Merged

adjust configuration for metrics #115

merged 2 commits into from
Dec 29, 2023

Conversation

Disper
Copy link
Member

@Disper Disper commented Dec 28, 2023 •
edited
Loading

Description
Having initial metrics available in Plutono will make it easier to work on the final ones.

Changes proposed in this pull request:

  • configures IM's metrics so first metrics should be accessible in Plutono
  • ...
  • ...

Related issue(s)

@Disper Disper requested a review from a team as a code owner December 28, 2023 13:46
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 28, 2023
VOID404
VOID404 approved these changes Dec 29, 2023
View reviewed changes
Copy link
Contributor

@VOID404 VOID404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if the metrics monitor is correct in this form, but this is just for our use, not prod

@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 29, 2023
@kyma-bot kyma-bot merged commit 3ab67d9 into kyma-project:main Dec 29, 2023
7 checks passed
@Disper Disper deleted the metrics branch December 29, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VOID404 VOID404 VOID404 approved these changes

Assignees

@VOID404 VOID404

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Disper @VOID404 @kyma-bot