infrastructure manager metrics (2/n) #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
kyma-bot
added
cla: yes
kyma-bot
added
size/L
kyma-bot
removed
the
do-not-merge/work-in-progress
Disper
changed the title
VOID404
reviewed
Mar 6, 2024
| if errorMetric != nil { | ||
| errorMetric.Set(0) | ||
| } | ||
| fmt.Printf("GardenerClusterStates set value to 0 for %v", runtimeID) |
There was a problem hiding this comment.
Could we use logger for logging? Rest of the code uses logr.Logger
There was a problem hiding this comment.
I've removed this debug line
VOID404
reviewed
Mar 8, 2024
| } | ||
|
|
||
| func IncrementReconciliationLoopsStarted() { | ||
| playgroundTotalReconciliationLoopsStarted.Inc() | ||
| func (m Metrics) UnSetGardenerClusterStates(runtimeID string) { |
There was a problem hiding this comment.
this function is pointless, isn't it? Just make CleanUpGardenerClusterGauge public
There was a problem hiding this comment.
Good point! fixed in dec8b6d
VOID404
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Should work better than the current metrics but will need additional adjustments:
Related issue(s)
#11