Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compare directories in the shoot_comparator tool #310

Merged
merged 16 commits into from
Aug 6, 2024
Merged

Compare directories in the shoot_comparator tool #310

merged 16 commits into from
Aug 6, 2024

Conversation

akgalwas
Copy link
Contributor

@akgalwas akgalwas commented Jul 25, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Added directories comparison functionality to shoot_comparator tool

Related issue(s)
#185

@akgalwas akgalwas requested a review from a team as a code owner July 25, 2024 07:24
@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 25, 2024
@akgalwas akgalwas mentioned this pull request Jul 25, 2024
Closed
4 tasks
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 29, 2024
@akgalwas akgalwas requested a review from a team as a code owner July 30, 2024 07:23
@akgalwas akgalwas changed the title [WiP] Compare directories in the shoot_comparator tool Compare directories in the shoot_comparator tool Jul 30, 2024
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 30, 2024
@koala7659 koala7659 requested a review from m00g3n July 30, 2024 07:51
grego952
grego952 previously approved these changes Jul 30, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 30, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jul 30, 2024
m00g3n
m00g3n approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@m00g3n m00g3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 5, 2024
@kyma-bot kyma-bot merged commit 4c950b8 into kyma-project:main Aug 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grego952 grego952 grego952 approved these changes

@m00g3n m00g3n m00g3n approved these changes

Assignees

@m00g3n m00g3n

@grego952 grego952

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akgalwas @m00g3n @grego952 @kyma-bot