Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add job that executes shoot comparison #321

Merged
merged 9 commits into from
Aug 6, 2024
Merged

Add job that executes shoot comparison #321

merged 9 commits into from
Aug 6, 2024

Conversation

akgalwas
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Yaml files prepared
  • Simple helper scripts implemented

Related issue(s)
#185

@akgalwas akgalwas requested review from a team as code owners July 31, 2024 16:29
@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 31, 2024
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 1, 2024
@akgalwas akgalwas changed the title [WiP] Add job that executes shoot comparison Add job that executes shoot comparison Aug 1, 2024
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 1, 2024
@akgalwas akgalwas requested a review from koala7659 August 1, 2024 13:47
@akgalwas akgalwas mentioned this pull request Aug 1, 2024
Closed
4 tasks
@koala7659 koala7659 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2024
koala7659
koala7659 reviewed Aug 2, 2024
View reviewed changes
hack/shoot-comparator/README.md Outdated
- garden-kyma-dev-a3008c5.yaml
------------------------------------------------------------------------------------------
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add one or two sentences with information that all created resources are left on the cluster and the user should delete them manually after finishing comparison process.

koala7659
koala7659 previously approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@koala7659 koala7659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - small remark - please check my comment

@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 2, 2024
@akgalwas akgalwas dismissed koala7659’s stale review August 6, 2024 06:10

The merge-base changed after approval.

@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 6, 2024
m00g3n
m00g3n previously approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@m00g3n m00g3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 6, 2024
koala7659
koala7659 previously approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@koala7659 koala7659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

grego952
grego952 reviewed Aug 6, 2024
View reviewed changes
hack/shoot-comparator/scripts/README.md Outdated Show resolved Hide resolved
hack/shoot-comparator/scripts/README.md Outdated Show resolved Hide resolved
hack/shoot-comparator/scripts/README.md Outdated Show resolved Hide resolved
@akgalwas akgalwas dismissed stale reviews from koala7659 and m00g3n via 5b18032 August 6, 2024 10:47
@akgalwas @grego952
Apply suggestions from code review
5b18032 
Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Aug 6, 2024
m00g3n
m00g3n approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@m00g3n m00g3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 6, 2024
@koala7659 koala7659 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 6, 2024
@kyma-bot kyma-bot merged commit c1fb9fb into kyma-project:main Aug 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grego952 grego952 grego952 approved these changes

@m00g3n m00g3n m00g3n approved these changes

@koala7659 koala7659 koala7659 left review comments

Assignees

@koala7659 koala7659

@m00g3n m00g3n

@grego952 grego952

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@akgalwas @koala7659 @m00g3n @grego952 @kyma-bot