generated from kyma-project/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Kim FSM operations timeout #325
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
cla: yes
Indicates the PR's author has signed the CLA.
labels
Aug 4, 2024
kyma-bot
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
Aug 4, 2024
koala7659
force-pushed
the
kim-fsm-operations-timeout
branch
from
August 4, 2024 10:39
202c144
to
2059974
Compare
koala7659
force-pushed
the
kim-fsm-operations-timeout
branch
from
August 5, 2024 06:50
2059974
to
a1e9c9c
Compare
kyma-bot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
and removed
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Aug 5, 2024
kyma-bot
added
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
and removed
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Aug 6, 2024
kyma-bot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
and removed
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Aug 6, 2024
kyma-bot
added
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
and removed
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Aug 6, 2024
Closing as we decided this functionality will not be part of KIM and we will use Gardener shoot state to determine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla: yes
Indicates the PR's author has signed the CLA.
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The operations processed by the KIM service in the Runtime CR controller reconciliation loop are interrupted after the timeout period has elapsed. KIM is configured with parameters:
Implementation
The moment every new operation starts by Runtime controller - a new annotation is added to RuntimeCR with the current timestamp. Example:
kyma-project.io/runtime-operation-started: "2024-08-09T05:06:02Z"
During each reconciliation cycle - the current time is checked against saved timestamp and configuration parameter.
When operation succeeds on Gardener side before timeout - the Runtime CR status is switched in Ready state and timestamp annotation is removed from
Runtime CR
.When operation does on Gardener side before timeout - the Runtime CR status is switched in Failed state and timestamp annotation remains on
Runtime CR
to prevent any further reconciliation attempts.Recovery
If the timeout during Update function occurs - user (KEB) can fix broken configuration that has timeout by manually deleting annotation in the Runtime instance:
kyma-project.io/runtime-operation-started:
In such a case Runtime reconciler will Patch Gardner shoot with fixed configuration and will start next upgrade cycle and wait for operation to be completed on Gardener side.
Output
Provisioning timeout:
Deprovisioning timeout:
Upgrade timeout:
Related issue(s)
#324