Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WiP] Fixes to make KIM produce the same output as Provisioner #341

Closed
wants to merge 12 commits into from
Closed

[WiP] Fixes to make KIM produce the same output as Provisioner #341

wants to merge 12 commits into from

Conversation

akgalwas
Copy link
Contributor

@akgalwas akgalwas commented Aug 13, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Deprecated field worker set for GCP provider to make comparison easier
  • Missing enableStaticKubeconfig set to false
  • Minor refactoring in matchers

Related issue(s)
#343

@akgalwas akgalwas requested a review from a team as a code owner August 13, 2024 14:41
@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 13, 2024
@akgalwas akgalwas mentioned this pull request Aug 22, 2024
Open
23 tasks
@akgalwas akgalwas closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Indicates the PR's author has signed the CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akgalwas @kyma-bot